Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-host-ipmid / 1e12112baf56f9a8ec6dbf7fb409c84f35fff1e8
commit1e12112baf56f9a8ec6dbf7fb409c84f35fff1e8[log] [tgz]
authorJames Feist <james.feist@linux.intel.com>Tue Jul 31 11:44:09 2018 -0700
committerTom Joseph <tomjoseph@in.ibm.com>Thu Aug 09 19:37:07 2018 +0000
tree6574eaa7230f377cfbc075d9cbaefc6e4341bc56
parentbed2699f47c34aa547f85e8d66d50df21be12a0a [diff]
Use visitor instead of pulling values directly

Sensor thresholds pull out an int64_t and immediately
assign it to a double. Use a visitor instead to avoid
the intermediate and add flexibility / saftey to type
readings.

Tested-By: Verifed sensor list still worked.
Change-Id: If49bf54ec1c0636b3549d433b86ecdbd1ea99b0d
Signed-off-by: James Feist <james.feist@linux.intel.com>
2 files changed
tree: 6574eaa7230f377cfbc075d9cbaefc6e4341bc56
  1. app/
  2. docs/
  3. host-ipmid/
  4. scripts/
  5. softoff/
  6. test/
  7. xyz/
  8. .build.sh
  9. .gitignore
  10. .travis.yml
  11. apphandler.cpp
  12. apphandler.h
  13. bootstrap.sh
  14. chassishandler.cpp
  15. chassishandler.h
  16. configure.ac
  17. dcmihandler.cpp
  18. dcmihandler.hpp
  19. elog-errors.hpp
  20. error-HostEvent.hpp
  21. fruread.hpp
  22. generate_whitelist.sh
  23. globalhandler.cpp
  24. globalhandler.h
  25. groupext.cpp
  26. host-cmd-manager.cpp
  27. host-cmd-manager.hpp
  28. host-interface.cpp
  29. host-interface.hpp
  30. host-ipmid-whitelist.conf
  31. ipmi_fru_info_area.cpp
  32. ipmi_fru_info_area.hpp
  33. ipmid.cpp
  34. ipmid.hpp
  35. ipmisensor.cpp
  36. ipmiwhitelist.hpp
  37. LICENSE
  38. MAINTAINERS
  39. Makefile.am
  40. net.cpp
  41. net.hpp
  42. oemrouter.cpp
  43. read_fru_data.cpp
  44. read_fru_data.hpp
  45. README.md
  46. sample.cpp
  47. sample.h
  48. selutility.cpp
  49. selutility.hpp
  50. sensordatahandler.cpp
  51. sensordatahandler.hpp
  52. sensorhandler.cpp
  53. sensorhandler.h
  54. settings.cpp
  55. settings.hpp
  56. storageaddsel.cpp
  57. storageaddsel.h
  58. storagehandler.cpp
  59. storagehandler.h
  60. systemintfcmds.cpp
  61. systemintfcmds.h
  62. testaddsel.cpp
  63. testit.cpp
  64. timer.cpp
  65. timer.hpp
  66. transporthandler.cpp
  67. transporthandler.hpp
  68. types.hpp
  69. utils.cpp
  70. utils.hpp
README.md

To build this package, do the following steps:

1. ./bootstrap.sh
2. ./configure ${CONFIGURE_FLAGS}
3. make

To clean the repository run ./bootstrap.sh clean.