Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-host-ipmid / 202702b0b20d0499877b50c5733879e409d43395
commit202702b0b20d0499877b50c5733879e409d43395[log] [tgz]
authorJonathan Doman <jonathan.doman@intel.com>Fri Sep 15 16:21:22 2023 -0700
committerJonathan Doman <jonathan.doman@intel.com>Fri Sep 15 16:21:22 2023 -0700
tree91bb92ac5c0e4a1c84a188fc4278a050aa1cd483
parent1b42a9c58f4bb6fc6c4f306e42c0544018064892 [diff]
Fix std::optional maybe-uninitialized (maybe?)

Attempt to fix the GCC waybe-uninitialized warning for unpackArgs. It
only triggers on compilation of one command handler
(ipmiSensorGetDeviceSdrInfo) with a single std::optional<uint8_t> param.

The warning is a false positive (I think) but GCC seems to like it if we
get rid of the empty emplace() call in the underlying std::optional
unpack function.

Tested: Compiles in the unit-test docker environment when configured
with `meson setup --reconfigure build -Dwerror=true -Dwarning_level=3
--buildtype=debugoptimized`

Change-Id: Ida8b82dbf2227d3b5339cd4b5756729eeeea9e1d
Signed-off-by: Jonathan Doman <jonathan.doman@intel.com>
2 files changed
tree: 91bb92ac5c0e4a1c84a188fc4278a050aa1cd483
  1. app/
  2. dbus-sdr/
  3. docs/
  4. include/
  5. libipmid/
  6. scripts/
  7. softoff/
  8. subprojects/
  9. test/
  10. user_channel/
  11. xyz/
  12. .build.sh
  13. .clang-format
  14. .gitignore
  15. .shellcheck
  16. .travis.yml
  17. apphandler.cpp
  18. apphandler.hpp
  19. chassishandler.cpp
  20. chassishandler.hpp
  21. dcmihandler.cpp
  22. dcmihandler.hpp
  23. error-HostEvent.hpp
  24. fruread.hpp
  25. generate_whitelist.sh
  26. generate_whitelist_create.sh
  27. globalhandler.cpp
  28. globalhandler.hpp
  29. groupext.cpp
  30. host-cmd-manager.cpp
  31. host-cmd-manager.hpp
  32. host-interface.cpp
  33. host-interface.hpp
  34. host-ipmid-whitelist.conf
  35. ipmi_fru_info_area.cpp
  36. ipmi_fru_info_area.hpp
  37. ipmid-new.cpp
  38. ipmisensor.cpp
  39. ipmiwhitelist.hpp
  40. LICENSE
  41. meson.build
  42. meson.options
  43. OWNERS
  44. read_fru_data.cpp
  45. read_fru_data.hpp
  46. README.md
  47. selutility.cpp
  48. selutility.hpp
  49. sensordatahandler.cpp
  50. sensordatahandler.hpp
  51. sensorhandler.cpp
  52. sensorhandler.hpp
  53. settings.cpp
  54. settings.hpp
  55. storageaddsel.cpp
  56. storageaddsel.hpp
  57. storagehandler.cpp
  58. storagehandler.hpp
  59. sys_info_param.cpp
  60. sys_info_param.hpp
  61. systemintfcmds.cpp
  62. systemintfcmds.hpp
  63. testaddsel.cpp
  64. testit.cpp
  65. transporthandler.cpp
  66. transporthandler.hpp
  67. whitelist-filter.cpp
README.md

Compile ipmid with default options:

meson builddir
ninja -C builddir

Compile ipmid with yocto defaults:

meson builddir -Dbuildtype=minsize -Db_lto=true -Dtests=disabled
ninja -C builddir

If any of the dependencies are not found on the host system during configuration, meson automatically gets them via its wrap dependencies mentioned in ipmid/subprojects.

Enable/Disable meson wrap feature

meson builddir -Dwrap_mode=nofallback
ninja -C builddir

Enable debug traces

meson builddir -Dbuildtype=debug
ninja -C builddir

Generate test coverage report:

meson builddir -Db_coverage=true -Dtests=enabled
ninja -C builddir test
ninja -C builddir coverage