Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-host-ipmid / 25bc7ac647ce216b1d6a4f4dcb55beadb064ced6
commit25bc7ac647ce216b1d6a4f4dcb55beadb064ced6[log] [tgz]
authorWilliam A. Kennington III <wak@google.com>Thu Mar 15 11:48:41 2018 -0700
committerWilliam A. Kennington III <wak@google.com>Mon Apr 02 23:35:10 2018 +0000
tree04c9582744494741e9a9035fdee3eff49d9ff857
parent7f2d7c90a27aacb45fa5ccc18c777593e007d2a7 [diff]
watchdog: Cache service name

We have occasionally noticed that the watchdog will be enabled and then
immediately trip upon booting of the BMC. This happens if the host is
still running when the BMC is coming up. Digging into the issue we notice
that the phosphor-mapper can be under very heavy load responding to all
of the initial mapping requests from BMC daemons starting. This causes a
delay in the phosphor-watchdog service name lookup during an attempt to
reset the watchdog countdown. The lookup delay is so long that the
watchdog ends up tripping before the reset is actually issued, causing
the BMC to reset the host. Since we know that the watchdog will not be
armed until the service resolves for the first time, we can reduce the
dependence and pressure on the service mapper by caching the service
name. Since it is the case that we want to keep issuing resets to the
same daemon that was initially configured, we should have no worries
about invalidating the cached service name. The name will be invalidated
any time we encounter a dbus level error issuing a watchdog commmand.

Change-Id: I303a39be997c2e57050b71efc8ef2e2cb27f8cf7
Signed-off-by: William A. Kennington III <wak@google.com>
2 files changed
tree: 04c9582744494741e9a9035fdee3eff49d9ff857
  1. app/
  2. docs/
  3. host-ipmid/
  4. scripts/
  5. softoff/
  6. test/
  7. xyz/
  8. .build.sh
  9. .gitignore
  10. .travis.yml
  11. apphandler.cpp
  12. apphandler.h
  13. bootstrap.sh
  14. chassishandler.cpp
  15. chassishandler.h
  16. configure.ac
  17. dcmihandler.cpp
  18. dcmihandler.hpp
  19. elog-errors.hpp
  20. error-HostEvent.hpp
  21. fruread.hpp
  22. generate_whitelist.sh
  23. globalhandler.cpp
  24. globalhandler.h
  25. groupext.cpp
  26. host-cmd-manager.cpp
  27. host-cmd-manager.hpp
  28. host-interface.cpp
  29. host-interface.hpp
  30. host-ipmid-whitelist.conf
  31. ipmi_fru_info_area.cpp
  32. ipmi_fru_info_area.hpp
  33. ipmid.cpp
  34. ipmid.hpp
  35. ipmisensor.cpp
  36. ipmiwhitelist.hpp
  37. LICENSE
  38. Makefile.am
  39. net.cpp
  40. net.hpp
  41. read_fru_data.cpp
  42. read_fru_data.hpp
  43. README.md
  44. sample.cpp
  45. sample.h
  46. selutility.cpp
  47. selutility.hpp
  48. sensordatahandler.cpp
  49. sensordatahandler.hpp
  50. sensorhandler.cpp
  51. sensorhandler.h
  52. settings.cpp
  53. settings.hpp
  54. storageaddsel.cpp
  55. storageaddsel.h
  56. storagehandler.cpp
  57. storagehandler.h
  58. systemintfcmds.cpp
  59. systemintfcmds.h
  60. testaddsel.cpp
  61. testit.cpp
  62. timer.cpp
  63. timer.hpp
  64. transporthandler.cpp
  65. transporthandler.hpp
  66. types.hpp
  67. utils.cpp
  68. utils.hpp
README.md

To build this package, do the following steps:

1. ./bootstrap.sh
2. ./configure ${CONFIGURE_FLAGS}
3. make

To full clean the repository again run ./bootstrap.sh clean.