Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-host-ipmid / 27a62ecab8ff322da41f53a1ffd0b2ca60eed7a9
commit27a62ecab8ff322da41f53a1ffd0b2ca60eed7a9[log] [tgz]
authorJeffLin <JeffLin2@quantatw.com>Wed Nov 24 15:40:33 2021 +0800
committerVernon Mauery <vernon.mauery@linux.intel.com>Tue Mar 08 00:21:41 2022 +0000
treea084de3015f0f1477ec1b55a6e5593d1a05f920e
parent071d00c5eb9e1f6d180b7b88d9db2a88b49ff852 [diff]
Fix firmware revision is always 0.00

Sometimes ipmid will show "Could not found an BMC software Object" in
journal and the firmware revision in command "ipmitool mc info" show
0.00 until BMC reboot or restart phosphor-ipmi-host.

Root cause is that the firmware revision will only try to get version
one time.

The issue happend when xyz.openbmc_project.Software.BMC.Updater.service
get started after the service phosphor-ipmi-host.service had been
started.
And the command "ipmitool mc info" is called before
xyz.openbmc_project.Software.BMC.Updater.service get started.

Tested:
Test the result of xyz.openbmc_project.Software.BMC.Updater.service get
started after phosphor-ipmi-host.service:

$ ipmitool mc info | grep 'Firmware Revision'
Firmware Revision         : 2.09

$ systemctl stop xyz.openbmc_project.Software.BMC.Updater.service
$ systemctl restart phosphor-ipmi-host
$ ipmitool mc info | grep 'Firmware Revision'
Firmware Revision         : 0.00

$ systemctl start xyz.openbmc_project.Software.BMC.Updater.service
$ ipmitool mc info | grep 'Firmware Revision'
Firmware Revision         : 2.09

Signed-off-by: JeffLin <JeffLin2@quantatw.com>
Change-Id: Icd82d114d74a8f5cc778886d8392527a8c71907b
1 file changed
tree: a084de3015f0f1477ec1b55a6e5593d1a05f920e
  1. app/
  2. dbus-sdr/
  3. docs/
  4. include/
  5. libipmid/
  6. libipmid-host/
  7. scripts/
  8. softoff/
  9. test/
  10. user_channel/
  11. xyz/
  12. .build.sh
  13. .clang-format
  14. .gitignore
  15. .shellcheck
  16. .travis.yml
  17. apphandler.cpp
  18. apphandler.hpp
  19. bootstrap.sh
  20. chassishandler.cpp
  21. chassishandler.hpp
  22. configure.ac
  23. dcmihandler.cpp
  24. dcmihandler.hpp
  25. elog-errors.hpp
  26. entity_map_json.cpp
  27. entity_map_json.hpp
  28. error-HostEvent.hpp
  29. fruread.hpp
  30. generate_whitelist.sh
  31. globalhandler.cpp
  32. globalhandler.hpp
  33. groupext.cpp
  34. host-cmd-manager.cpp
  35. host-cmd-manager.hpp
  36. host-interface.cpp
  37. host-interface.hpp
  38. host-ipmid-whitelist.conf
  39. ipmi_fru_info_area.cpp
  40. ipmi_fru_info_area.hpp
  41. ipmid-new.cpp
  42. ipmisensor.cpp
  43. ipmiwhitelist.hpp
  44. LICENSE
  45. MAINTAINERS
  46. Makefile.am
  47. OWNERS
  48. read_fru_data.cpp
  49. read_fru_data.hpp
  50. README.md
  51. sample.cpp
  52. sample.h
  53. selutility.cpp
  54. selutility.hpp
  55. sensordatahandler.cpp
  56. sensordatahandler.hpp
  57. sensorhandler.cpp
  58. sensorhandler.hpp
  59. settings.cpp
  60. settings.hpp
  61. storageaddsel.cpp
  62. storageaddsel.hpp
  63. storagehandler.cpp
  64. storagehandler.hpp
  65. sys_info_param.cpp
  66. sys_info_param.hpp
  67. systemintfcmds.cpp
  68. systemintfcmds.hpp
  69. testaddsel.cpp
  70. testit.cpp
  71. transporthandler.cpp
  72. transporthandler.hpp
  73. whitelist-filter.cpp
README.md

To build this package, do the following steps:

1. ./bootstrap.sh
2. ./configure ${CONFIGURE_FLAGS}
3. make

To clean the repository run ./bootstrap.sh clean.