Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-host-ipmid / 29b9f31d55cff3cebd7f95ab05dc8fc8acfb2828
commit29b9f31d55cff3cebd7f95ab05dc8fc8acfb2828[log] [tgz]
authorAyushi Smriti <smriti.ayushi@linux.intel.com>Fri Sep 24 12:29:23 2021 +0530
committersmriti.ayushi <smriti.ayushi@linux.intel.com>Thu Sep 30 08:23:36 2021 +0000
tree87d5a6461aaa6c3c07f5c3333da2b504134d02b2
parentb3f74ace5c6d83d2b6f888ebe5dbaca98c233e21 [diff]
Fix: Set User Password cmd fails with 0xc7 CC

Issue: Set User Password command (47h) fails with 0xc7 req data length
invalid CC on disable/enable user operation.
According to the IPMI spec, the 'password data' req bytes in Set User
Password cmd need not be present if the operation is ‘disable user’ or
‘enable user’.

This change adds proper checks to address the above issue.

Tested:
Executed set user password cmd and verified success response

previous:
root@intel-obmc:~# ipmitool raw 0x06 0x47 0x02 0x00
Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0 cmd=0x47
rsp=0xc7): Request data length invalid
root@intel-obmc:~# ipmitool raw 0x06 0x47 0x02 0x01
Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0 cmd=0x47
rsp=0xc7): Request data length invalid

After fix:
root@intel-obmc:~# ipmitool raw 0x06 0x47 0x02 0x00

root@intel-obmc:~# ipmitool raw 0x06 0x47 0x02 0x01

Change-Id: Idad719e75abb37d6aebff510ea2339a93bea84dd
Signed-off-by: Ayushi Smriti <smriti.ayushi@linux.intel.com>
1 file changed
tree: 87d5a6461aaa6c3c07f5c3333da2b504134d02b2
  1. app/
  2. dbus-sdr/
  3. docs/
  4. include/
  5. libipmid/
  6. libipmid-host/
  7. scripts/
  8. softoff/
  9. test/
  10. user_channel/
  11. xyz/
  12. .build.sh
  13. .clang-format
  14. .gitignore
  15. .shellcheck
  16. .travis.yml
  17. apphandler.cpp
  18. apphandler.hpp
  19. bootstrap.sh
  20. chassishandler.cpp
  21. chassishandler.hpp
  22. configure.ac
  23. dcmihandler.cpp
  24. dcmihandler.hpp
  25. elog-errors.hpp
  26. entity_map_json.cpp
  27. entity_map_json.hpp
  28. error-HostEvent.hpp
  29. fruread.hpp
  30. generate_whitelist.sh
  31. globalhandler.cpp
  32. globalhandler.hpp
  33. groupext.cpp
  34. host-cmd-manager.cpp
  35. host-cmd-manager.hpp
  36. host-interface.cpp
  37. host-interface.hpp
  38. host-ipmid-whitelist.conf
  39. ipmi_fru_info_area.cpp
  40. ipmi_fru_info_area.hpp
  41. ipmid-new.cpp
  42. ipmisensor.cpp
  43. ipmiwhitelist.hpp
  44. LICENSE
  45. MAINTAINERS
  46. Makefile.am
  47. read_fru_data.cpp
  48. read_fru_data.hpp
  49. README.md
  50. sample.cpp
  51. sample.h
  52. selutility.cpp
  53. selutility.hpp
  54. sensordatahandler.cpp
  55. sensordatahandler.hpp
  56. sensorhandler.cpp
  57. sensorhandler.hpp
  58. settings.cpp
  59. settings.hpp
  60. storageaddsel.cpp
  61. storageaddsel.hpp
  62. storagehandler.cpp
  63. storagehandler.hpp
  64. sys_info_param.cpp
  65. sys_info_param.hpp
  66. systemintfcmds.cpp
  67. systemintfcmds.hpp
  68. testaddsel.cpp
  69. testit.cpp
  70. transporthandler.cpp
  71. transporthandler.hpp
  72. whitelist-filter.cpp
README.md

To build this package, do the following steps:

1. ./bootstrap.sh
2. ./configure ${CONFIGURE_FLAGS}
3. make

To clean the repository run ./bootstrap.sh clean.