Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-host-ipmid / 06a0abff0124d0d0ce58f51621b27a735aa888f5
commit06a0abff0124d0d0ce58f51621b27a735aa888f5[log] [tgz]
authorBrad Bishop <bradleyb@fuzziesquirrel.com>Mon Feb 26 20:46:00 2018 -0500
committerTom Joseph <tomjoseph@in.ibm.com>Wed Mar 07 12:14:00 2018 +0000
tree48d4889efcedf85b7b053fe7abcd3d0f83348cd4
parent5ca50959438c3c99acfafe4d0ff301eb29b84233 [diff]
sensors: rework sensor assertion

Prior to this patch the sensor assertion logic would generate an invalid
DBus message or undefined behavior in several scenarios.

 - A bit is both asserted and desasserted:
A well behaving client won't do this but the existing logic would
generate an invalid property-set message with signature ssvv.  Rework
the logic such that no dbus traffic occurs.

 -  No bits are asserted:
Results in an invalid message with signature ss.
Rework such that no dbus traffic occurs.

 - Empty offset value map in configuration:
Results in an invalid message with signature s.
Rework such that no dbus traffic occurs.

 - Empty offset value map entry (either assert or deassert) in
   configuration:
Results in an invalid variant signature.
Rework such that no dbus traffic occurs.

 - The same bit is specified in the configuration for multiple
   properties or interfaces:
Can result in invalid messages with a wide variety of signatures.
Rework such that one message is sent for each property
being updated.

 - Invalid bit specified in value map entry
Results in undefined behavior calling bitset::test.
Rework such that entries in the value map with invalid bits
are ignored.

Tested: Verified the OperatingSystemStatus sensor can be set by a BIOS
Change-Id: I4df9472a8bdc9e44e98e1a963838da0912d10683
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
1 file changed
tree: 48d4889efcedf85b7b053fe7abcd3d0f83348cd4
  1. app/
  2. docs/
  3. host-ipmid/
  4. scripts/
  5. softoff/
  6. test/
  7. xyz/
  8. .build.sh
  9. .gitignore
  10. .travis.yml
  11. apphandler.cpp
  12. apphandler.h
  13. bootstrap.sh
  14. chassishandler.cpp
  15. chassishandler.h
  16. configure.ac
  17. dcmihandler.cpp
  18. dcmihandler.hpp
  19. elog-errors.hpp
  20. error-HostEvent.hpp
  21. fruread.hpp
  22. generate_whitelist.sh
  23. globalhandler.cpp
  24. globalhandler.h
  25. groupext.cpp
  26. host-cmd-manager.cpp
  27. host-cmd-manager.hpp
  28. host-interface.cpp
  29. host-interface.hpp
  30. host-ipmid-whitelist.conf
  31. ipmi_fru_info_area.cpp
  32. ipmi_fru_info_area.hpp
  33. ipmid.cpp
  34. ipmid.hpp
  35. ipmisensor.cpp
  36. ipmiwhitelist.hpp
  37. LICENSE
  38. Makefile.am
  39. net.cpp
  40. net.hpp
  41. read_fru_data.cpp
  42. read_fru_data.hpp
  43. README.md
  44. sample.cpp
  45. sample.h
  46. selutility.cpp
  47. selutility.hpp
  48. sensordatahandler.cpp
  49. sensordatahandler.hpp
  50. sensorhandler.cpp
  51. sensorhandler.h
  52. settings.cpp
  53. settings.hpp
  54. storageaddsel.cpp
  55. storageaddsel.h
  56. storagehandler.cpp
  57. storagehandler.h
  58. systemintfcmds.cpp
  59. systemintfcmds.h
  60. testaddsel.cpp
  61. testit.cpp
  62. timer.cpp
  63. timer.hpp
  64. transporthandler.cpp
  65. transporthandler.hpp
  66. types.hpp
  67. utils.cpp
  68. utils.hpp
README.md

To build this package, do the following steps:

1. ./bootstrap.sh
2. ./configure ${CONFIGURE_FLAGS}
3. make

To full clean the repository again run ./bootstrap.sh clean.