commit 45d4193137b3e23b90a210e10c65ef8ba376eb81
author Willy Tu <wltu@google.com> Mon Oct 17 19:49:32 2022 +0000
committer Willy Tu <wltu@google.com> Mon Oct 17 19:51:09 2022 +0000
tree 9c8421b7bbcca913ecccadcb5223160ea30b12da
parent 76889090d85dade0e4c486cbd4977d8275765fbe

cleanup Secure types

Removed `std::allocator::rebind` since it has been
(deprecated in C++17)(removed in C++20). Also cleaned up the
OPENSSL_cleanse for SecureString and SecureBuffer to just point to the
beginning of the data with `this->data()`.

Change-Id: I3bd5b65171a4c5b49f8747d13984e1ce96c00190
Signed-off-by: Willy Tu <wltu@google.com>

include/ipmid/types.hpp

diff --git a/include/ipmid/types.hpp b/include/ipmid/types.hpp
index 8d65b0f..a36d612 100644
--- a/include/ipmid/types.hpp
+++ b/include/ipmid/types.hpp
@@ -269,12 +269,6 @@
 class SecureAllocator : public std::allocator<T>
 {
   public:
-    template <typename U>
-    struct rebind
-    {
-        typedef SecureAllocator<U> other;
-    };
-
     void deallocate(T* p, size_t n)
     {
         OPENSSL_cleanse(p, n);
@@ -297,7 +291,7 @@
 
     ~SecureString()
     {
-        OPENSSL_cleanse(&((*this)[0]), this->size());
+        OPENSSL_cleanse(this->data(), this->size());
     }
 };
 
@@ -316,7 +310,7 @@
 
     ~SecureBuffer()
     {
-        OPENSSL_cleanse(&((*this)[0]), this->size());
+        OPENSSL_cleanse(this->data(), this->size());
     }
 };
 } // namespace ipmi