commit 4ec4e40a44d68efb7f70603aa5bda5a4f96f2de5
author Vernon Mauery <vernon.mauery@linux.intel.com> Wed Mar 20 13:09:27 2019 -0700
committer Vernon Mauery <vernon.mauery@linux.intel.com> Mon Mar 25 16:18:21 2019 +0000
tree 9005430a2bed55e8a78cffd393ee745847599f59
parent 2fe9282fc4f05626bb42566530a4b618e40b7f22

do not use auto and rename handles to providers

handles is a poor name choice for the list of IpmiProviders and being
declared as an auto is hard to see what type it really is. This changes
the type to be fixed and uses a more appropriate name for the variable.

Change-Id: I35f744c491f3810c7381738516b8ff0a6f20f129
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

ipmid-new.cpp

diff --git a/ipmid-new.cpp b/ipmid-new.cpp
index ed45173..a92d4c4 100644
--- a/ipmid-new.cpp
+++ b/ipmid-new.cpp
@@ -599,7 +599,8 @@
     cmdManager = std::make_unique<phosphor::host::command::Manager>(*sdbusp);
 
     // Register all command providers and filters
-    auto handles = ipmi::loadProviders(HOST_IPMI_LIB_PATH);
+    std::forward_list<ipmi::IpmiProvider> providers =
+        ipmi::loadProviders(HOST_IPMI_LIB_PATH);
 
     // Add bindings for inbound IPMI requests
     auto server = sdbusplus::asio::object_server(sdbusp);
@@ -635,7 +636,7 @@
     ipmi::oemHandlerMap.clear();
     ipmi::filterList.clear();
     // unload the provider libraries
-    handles.clear();
+    providers.clear();
 
     return 0;
 }