Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-host-ipmid / 0d49e47978d5f2d0b108b0ddc65943763e88f729
commit0d49e47978d5f2d0b108b0ddc65943763e88f729[log] [tgz]
authorWilliam A. Kennington III <wak@google.com>Mon Apr 08 20:27:26 2019 -0700
committerWilliam A. Kennington III <wak@google.com>Thu Apr 11 18:40:25 2019 -0700
tree73aaa9c1141a2e7425e92cb0ff660e0afcf7331e
parent11df4f6906edc0dfb23089a6e297158549c19ebd [diff]
message/unpack: Fix undefined behavior

It's UB to shift an integer by the size of that integer. More
specifically, if you disable compiler optimization and try and unpack a
32 bit bitset you will end up with a 0x0 mask. Avoid UB by replacing
shift subtract with a negate shift.

Tested:
    Unit tests pass now.

Change-Id: I03a6f866a51c955b57787d641da9180841747e4c
Signed-off-by: William A. Kennington III <wak@google.com>
1 file changed
tree: 73aaa9c1141a2e7425e92cb0ff660e0afcf7331e
  1. app/
  2. docs/
  3. include/
  4. libipmid/
  5. libipmid-host/
  6. scripts/
  7. softoff/
  8. test/
  9. user_channel/
  10. xyz/
  11. .build.sh
  12. .clang-format
  13. .gitignore
  14. .travis.yml
  15. apphandler.cpp
  16. apphandler.hpp
  17. bootstrap.sh
  18. chassishandler.cpp
  19. chassishandler.hpp
  20. configure.ac
  21. dcmihandler.cpp
  22. dcmihandler.hpp
  23. elog-errors.hpp
  24. error-HostEvent.hpp
  25. fruread.hpp
  26. generate_whitelist.sh
  27. globalhandler.cpp
  28. globalhandler.hpp
  29. groupext.cpp
  30. host-cmd-manager.cpp
  31. host-cmd-manager.hpp
  32. host-interface.cpp
  33. host-interface.hpp
  34. host-ipmid-whitelist.conf
  35. ipmi_fru_info_area.cpp
  36. ipmi_fru_info_area.hpp
  37. ipmid-new.cpp
  38. ipmisensor.cpp
  39. ipmiwhitelist.hpp
  40. LICENSE
  41. MAINTAINERS
  42. Makefile.am
  43. oemrouter.cpp
  44. read_fru_data.cpp
  45. read_fru_data.hpp
  46. README.md
  47. sample.cpp
  48. sample.h
  49. selutility.cpp
  50. selutility.hpp
  51. sensordatahandler.cpp
  52. sensordatahandler.hpp
  53. sensorhandler.cpp
  54. sensorhandler.hpp
  55. settings.cpp
  56. settings.hpp
  57. storageaddsel.cpp
  58. storageaddsel.hpp
  59. storagehandler.cpp
  60. storagehandler.hpp
  61. sys_info_param.cpp
  62. sys_info_param.hpp
  63. systemintfcmds.cpp
  64. systemintfcmds.hpp
  65. testaddsel.cpp
  66. testit.cpp
  67. transporthandler.cpp
  68. transporthandler.hpp
  69. whitelist-filter.cpp
README.md

To build this package, do the following steps:

1. ./bootstrap.sh
2. ./configure ${CONFIGURE_FLAGS}
3. make

To clean the repository run ./bootstrap.sh clean.