commit 572bac1735aef5587b72a26d760d875908919352
author Yong Li <yong.b.li@linux.intel.com> Tue May 14 12:57:03 2019 +0800
committer Yong Li <yong.b.li@intel.com> Fri May 17 23:21:18 2019 +0000
tree e1c10c73804368ea230f59998320f048fa66cec5
parent 5ed395951d17f4f2616c21345cd6652779c8b300

Remove the global warm reset ipmi command

This warm reset command is using the duplicated API as cold reset.
As per IPMI spec, warm reset should not alter volatile settings,
and has to just reset the interface which is not what current code does.
Hence to avoid confusion, remove this warm reset command

Tested:
"ipmitool raw 6 3" command return "Invalid command",
and BMC does not reboot

Signed-off-by: Yong Li <yong.b.li@linux.intel.com>
Change-Id: I62f37c9b8386a817ce069c26ade6760de73b1d16
Signed-off-by: Yong Li <yong.b.li@linux.intel.com>

globalhandler.cpp

diff --git a/globalhandler.cpp b/globalhandler.cpp
index f6b24ac..c192cbb 100644
--- a/globalhandler.cpp
+++ b/globalhandler.cpp
@@ -59,9 +59,5 @@
     ipmi::registerHandler(ipmi::prioOpenBmcBase, ipmi::netFnApp,
                           ipmi::app::cmdColdReset, ipmi::Privilege::Admin,
                           ipmiGlobalReset);
-    // Warm Reset
-    ipmi::registerHandler(ipmi::prioOpenBmcBase, ipmi::netFnApp,
-                          ipmi::app::cmdWarmReset, ipmi::Privilege::Admin,
-                          ipmiGlobalReset);
     return;
 }

globalhandler.hpp

diff --git a/globalhandler.hpp b/globalhandler.hpp
index 23d3b3e..078b170 100644
--- a/globalhandler.hpp
+++ b/globalhandler.hpp
@@ -6,5 +6,4 @@
 enum ipmi_global_control_cmds : uint8_t
 {
     IPMI_CMD_COLD_RESET = 0x02,
-    IPMI_CMD_WARM_RESET = 0x03,
 };