commit 57d4a830c36fbbecea6f923f6223f03cb14f6321
author Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com> Tue Jan 29 11:10:29 2019 +0530
committer Tom Joseph <tomjoseph@in.ibm.com> Fri Feb 01 18:50:43 2019 +0000
tree bb254e8cc7bd5d76eea533f3958829330a167a50
parent 54fad6de0541c2f98e9b511f1d30bbcbcd743db6

Fix: NoAccess priv is tied with empty priv attr

SetUserAccess command must accept NoAccess privilege
and update user-manager with empty privilege attribute
for that user.

Unit-test:
verified it using following command, and access marked
as NoAccess when queriying user list
ipmitool raw 6 0x43 0x91 0x1 0x0f 0x00

Change-Id: Id63061edfc7777b7cb88c2cd7c693ea0b98c7949
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>

user_channel/user_mgmt.cpp

diff --git a/user_channel/user_mgmt.cpp b/user_channel/user_mgmt.cpp
index eb95163..3f82c15 100644
--- a/user_channel/user_mgmt.cpp
+++ b/user_channel/user_mgmt.cpp
@@ -686,10 +686,6 @@
     }
     std::string priv = convertToSystemPrivilege(
         static_cast<CommandPrivilege>(privAccess.privilege));
-    if (priv.empty())
-    {
-        return IPMI_CC_PARM_OUT_OF_RANGE;
-    }
     uint8_t syncIndex = getUsrMgmtSyncIndex();
     if (chNum == syncIndex &&
         privAccess.privilege != userInfo->userPrivAccess[syncIndex].privilege)