Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-host-ipmid / c1f5aca0651c297ae427bfa7e5dc2b897b66d40b
commitc1f5aca0651c297ae427bfa7e5dc2b897b66d40b[log] [tgz]
authorBrandon Kim <brandonkim@google.com>Thu Mar 17 17:54:06 2022 -0700
committerWilly Tu <wltu@google.com>Thu Mar 31 18:12:02 2022 +0000
treedf2e0e520833221f57ee6b5bccbba8ea81dace58
parent3ab2c2b2f3248317d28d717e56b29f19e36fc510 [diff]
apphandler: Fix Device Revision being 0

If the Device Revision is set later, and therefore when convertVersion
returns a negative return value at ipmid startup, we shouldn't be
setting the `haveBMCVersion` flag. Only when the convertVersion returned
a non-negative value and we received a proper Device ID, should we
set the flag.

Tested:
At boot, with a platform with Device Revision 1,

Without the change:
~# ipmitool mc info
Device ID                 : 0
Device Revision           : 0
Firmware Revision         : 16.03

With the change:
~# ipmitool mc info
Device ID                 : 0
Device Revision           : 1
Firmware Revision         : 16.03

Signed-off-by: Brandon Kim <brandonkim@google.com>
Change-Id: Ia7a4e2d21384bb840a082d7ec91ad0ed1722c0c7
1 file changed
tree: df2e0e520833221f57ee6b5bccbba8ea81dace58
  1. app/
  2. dbus-sdr/
  3. docs/
  4. include/
  5. libipmid/
  6. libipmid-host/
  7. scripts/
  8. softoff/
  9. test/
  10. user_channel/
  11. xyz/
  12. .build.sh
  13. .clang-format
  14. .gitignore
  15. .shellcheck
  16. .travis.yml
  17. apphandler.cpp
  18. apphandler.hpp
  19. bootstrap.sh
  20. chassishandler.cpp
  21. chassishandler.hpp
  22. configure.ac
  23. dcmihandler.cpp
  24. dcmihandler.hpp
  25. elog-errors.hpp
  26. entity_map_json.cpp
  27. entity_map_json.hpp
  28. error-HostEvent.hpp
  29. fruread.hpp
  30. generate_whitelist.sh
  31. globalhandler.cpp
  32. globalhandler.hpp
  33. groupext.cpp
  34. host-cmd-manager.cpp
  35. host-cmd-manager.hpp
  36. host-interface.cpp
  37. host-interface.hpp
  38. host-ipmid-whitelist.conf
  39. ipmi_fru_info_area.cpp
  40. ipmi_fru_info_area.hpp
  41. ipmid-new.cpp
  42. ipmisensor.cpp
  43. ipmiwhitelist.hpp
  44. LICENSE
  45. MAINTAINERS
  46. Makefile.am
  47. OWNERS
  48. read_fru_data.cpp
  49. read_fru_data.hpp
  50. README.md
  51. sample.cpp
  52. sample.h
  53. selutility.cpp
  54. selutility.hpp
  55. sensordatahandler.cpp
  56. sensordatahandler.hpp
  57. sensorhandler.cpp
  58. sensorhandler.hpp
  59. settings.cpp
  60. settings.hpp
  61. storageaddsel.cpp
  62. storageaddsel.hpp
  63. storagehandler.cpp
  64. storagehandler.hpp
  65. sys_info_param.cpp
  66. sys_info_param.hpp
  67. systemintfcmds.cpp
  68. systemintfcmds.hpp
  69. testaddsel.cpp
  70. testit.cpp
  71. transporthandler.cpp
  72. transporthandler.hpp
  73. whitelist-filter.cpp
README.md

To build this package, do the following steps:

1. ./bootstrap.sh
2. ./configure ${CONFIGURE_FLAGS}
3. make

To clean the repository run ./bootstrap.sh clean.