Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-host-ipmid / 6d5b2f7e1c6e142b6198be45e3766d7d8cf5c9bc
commit6d5b2f7e1c6e142b6198be45e3766d7d8cf5c9bc[log] [tgz]
authorVernon Mauery <vernon.mauery@linux.intel.com>Thu May 16 14:48:47 2019 -0700
committerVernon Mauery <vernon.mauery@linux.intel.com>Thu May 16 14:54:10 2019 -0700
tree398369ba8a79ba3666513d73dae4d1eda94e6254
parente004e221800a43b2569c0a337674433ffa61e7a4 [diff]
Get Chassis Status should not bail if button interfaces are not present

The recent rewrite of Get Chassis Status also added support for reading
the front panel enables status instead of returning a hard-coded false.
But the implementation also errors out if the interface is not present
This makes the interfaces optional, returning false if they are not presnt
and reading them correctly if they are.

Tested-by: running ipmitool chassis status with and without the
           xyz.openbmc_project.Chassis.Buttons service running:

           # ipmitool chassis status
           System Power         : on
           Power Overload       : false
           Power Interlock      : inactive
           Main Power Fault     : false
           Power Control Fault  : false
           Power Restore Policy : previous
           Last Power Event     :
           Chassis Intrusion    : inactive
           Front-Panel Lockout  : inactive
           Drive Fault          : false
           Cooling/Fan Fault    : false
           Sleep Button Disable : not allowed
           Diag Button Disable  : not allowed
           Reset Button Disable : allowed
           Power Button Disable : allowed
           Sleep Button Disabled: false
           Diag Button Disabled : false
           Reset Button Disabled: false
           Power Button Disabled: false

           # systemctl stop xyz.openbmc_project.Chassis.Buttons@0.service

           # ipmitool chassis status
           System Power         : on
           Power Overload       : false
           Power Interlock      : inactive
           Main Power Fault     : false
           Power Control Fault  : false
           Power Restore Policy : previous
           Last Power Event     :
           Chassis Intrusion    : inactive
           Front-Panel Lockout  : inactive
           Drive Fault          : false
           Cooling/Fan Fault    : false
           Front Panel Control  : none

Change-Id: If845194b6f052ba84f8b062ac4259ec66f706bb5
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>
1 file changed
tree: 398369ba8a79ba3666513d73dae4d1eda94e6254
  1. app/
  2. docs/
  3. include/
  4. libipmid/
  5. libipmid-host/
  6. scripts/
  7. softoff/
  8. test/
  9. user_channel/
  10. xyz/
  11. .build.sh
  12. .clang-format
  13. .gitignore
  14. .travis.yml
  15. apphandler.cpp
  16. apphandler.hpp
  17. bootstrap.sh
  18. chassishandler.cpp
  19. chassishandler.hpp
  20. configure.ac
  21. dcmihandler.cpp
  22. dcmihandler.hpp
  23. elog-errors.hpp
  24. error-HostEvent.hpp
  25. fruread.hpp
  26. generate_whitelist.sh
  27. globalhandler.cpp
  28. globalhandler.hpp
  29. groupext.cpp
  30. host-cmd-manager.cpp
  31. host-cmd-manager.hpp
  32. host-interface.cpp
  33. host-interface.hpp
  34. host-ipmid-whitelist.conf
  35. ipmi_fru_info_area.cpp
  36. ipmi_fru_info_area.hpp
  37. ipmid-new.cpp
  38. ipmisensor.cpp
  39. ipmiwhitelist.hpp
  40. LICENSE
  41. MAINTAINERS
  42. Makefile.am
  43. oemrouter.cpp
  44. read_fru_data.cpp
  45. read_fru_data.hpp
  46. README.md
  47. sample.cpp
  48. sample.h
  49. selutility.cpp
  50. selutility.hpp
  51. sensordatahandler.cpp
  52. sensordatahandler.hpp
  53. sensorhandler.cpp
  54. sensorhandler.hpp
  55. settings.cpp
  56. settings.hpp
  57. storageaddsel.cpp
  58. storageaddsel.hpp
  59. storagehandler.cpp
  60. storagehandler.hpp
  61. sys_info_param.cpp
  62. sys_info_param.hpp
  63. systemintfcmds.cpp
  64. systemintfcmds.hpp
  65. testaddsel.cpp
  66. testit.cpp
  67. transporthandler.cpp
  68. transporthandler.hpp
  69. whitelist-filter.cpp
README.md

To build this package, do the following steps:

1. ./bootstrap.sh
2. ./configure ${CONFIGURE_FLAGS}
3. make

To clean the repository run ./bootstrap.sh clean.