Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-host-ipmid / d5967afbbec5c0829ceb8e274f2e58954942757c
commitd5967afbbec5c0829ceb8e274f2e58954942757c[log] [tgz]
authorTony Lee <tony.lee@quantatw.com>Tue Jul 06 15:49:11 2021 +0800
committerVernon Mauery <vernon.mauery@linux.intel.com>Mon Jul 26 22:04:52 2021 +0000
treea6d12a25ebd569b3941217d2e7161898ed0bc2ea
parent89a83b6726ba4e75d1af1f0b3524fca955e28413 [diff]
Fix unexpected change of ipsrc of ipv6

Issue: The initial ipsrc of ipv6 is dhcp. When setting different static
ipv4 twice, ipv6 will become static.

Fix: Rewrite the if condition. setDHCPv4Property is only for IPv4
management. It should not modify IPv6 state.

Tested: Verified step as below:

1. Get dbus property 'DHCPEnabled' via
busctl get-property xyz.openbmc_project.Network
/xyz/openbmc_project/network/eth1
xyz.openbmc_project.Network.EthernetInterface DHCPEnabled
s "xyz.openbmc_project.Network.EthernetInterface.DHCPConf.both"

2. Set an static ipv4.
3. Set another static ipv4.
4. Check 'DHCPEnabled' is still v6 via dbus. And check the config
in 00-bmc-eth1.network without ipv6 static address.

Change-Id: I8b55c01a61e568555983fc462d4508f2860217be
Signed-off-by: Tony Lee <tony.lee@quantatw.com>
1 file changed
tree: a6d12a25ebd569b3941217d2e7161898ed0bc2ea
  1. app/
  2. dbus-sdr/
  3. docs/
  4. include/
  5. libipmid/
  6. libipmid-host/
  7. scripts/
  8. softoff/
  9. test/
  10. user_channel/
  11. xyz/
  12. .build.sh
  13. .clang-format
  14. .gitignore
  15. .shellcheck
  16. .travis.yml
  17. apphandler.cpp
  18. apphandler.hpp
  19. bootstrap.sh
  20. chassishandler.cpp
  21. chassishandler.hpp
  22. configure.ac
  23. dcmihandler.cpp
  24. dcmihandler.hpp
  25. elog-errors.hpp
  26. entity_map_json.cpp
  27. entity_map_json.hpp
  28. error-HostEvent.hpp
  29. fruread.hpp
  30. generate_whitelist.sh
  31. globalhandler.cpp
  32. globalhandler.hpp
  33. groupext.cpp
  34. host-cmd-manager.cpp
  35. host-cmd-manager.hpp
  36. host-interface.cpp
  37. host-interface.hpp
  38. host-ipmid-whitelist.conf
  39. ipmi_fru_info_area.cpp
  40. ipmi_fru_info_area.hpp
  41. ipmid-new.cpp
  42. ipmisensor.cpp
  43. ipmiwhitelist.hpp
  44. LICENSE
  45. MAINTAINERS
  46. Makefile.am
  47. read_fru_data.cpp
  48. read_fru_data.hpp
  49. README.md
  50. sample.cpp
  51. sample.h
  52. selutility.cpp
  53. selutility.hpp
  54. sensordatahandler.cpp
  55. sensordatahandler.hpp
  56. sensorhandler.cpp
  57. sensorhandler.hpp
  58. settings.cpp
  59. settings.hpp
  60. storageaddsel.cpp
  61. storageaddsel.hpp
  62. storagehandler.cpp
  63. storagehandler.hpp
  64. sys_info_param.cpp
  65. sys_info_param.hpp
  66. systemintfcmds.cpp
  67. systemintfcmds.hpp
  68. testaddsel.cpp
  69. testit.cpp
  70. transporthandler.cpp
  71. transporthandler.hpp
  72. whitelist-filter.cpp
README.md

To build this package, do the following steps:

1. ./bootstrap.sh
2. ./configure ${CONFIGURE_FLAGS}
3. make

To clean the repository run ./bootstrap.sh clean.