| commit | 84c49dc17fecc69bdb88dbc7cfb4b67eff81a4e6 | [log] [tgz] |
|---|---|---|
| author | jayaprakash Mutyala <mutyalax.jayaprakash@intel.com> | Mon May 18 23:12:13 2020 +0000 |
| committer | Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com> | Fri Jun 12 17:39:44 2020 +0000 |
| tree | 62d75993df8f30b1ab369358b932031f7375b48b | |
| parent | ecd9f378bf5e44d93d8f5be67ef9c20922e2e91a [diff] |
transporthandler: Fix for invalid VLAN id
Issue: Set LAN configuration, allowing invalid VLAN ID's and giving
exception when user trying to set VLAN.
Fix: Add condition to return proper error for invalid VLAN ID's and add
a condition to skip exception temporarily.
Tested:
Verified using ipmitool raw commands
Command: ipmitool raw 0x0c 0x01 0x1 0x14 0x00 0x80 //Set Lan, vlan id=0
Response: Unable to send RAW command (channel=0x0 netfn=0xc lun=0x0
cmd=0x1 rsp=0xcc): Invalid data field in request
Command: ipmitool raw 0x0c 0x01 0x1 0x14 0xff 0x8f
//Set Lan, vlan id=4095
Response: Unable to send RAW command (channel=0x0 netfn=0xc lun=0x0
cmd=0x1 rsp=0xcc): Invalid data field in request
Command: ipmitool raw 0x0c 0x01 0x1 0x14 0x00 0x82
Response: //Success
Command: ipmitool lan print 1
Response:
Set in Progress : Set Complete
Auth Type Support :
Auth Type Enable : Callback :
: User :
: Operator :
: Admin :
: OEM :
IP Address Source : DHCP Address
IP Address : 0.0.0.0
Subnet Mask : 255.255.255.255
MAC Address : a6:41:81:e8:39:33
Default Gateway IP : 10.190.164.1
Default Gateway MAC : 00:00:00:00:00:00
802.1q VLAN ID : 512
RMCP+ Cipher Suites : 17
Cipher Suite Priv Max : aaaaaaaaaaaaaaa
: X=Cipher Suite Unused
: c=CALLBACK
: u=USER
: o=OPERATOR
: a=ADMIN
: O=OEM
Bad Password Threshold : Not Available
Command: ipmitool raw 0x0c 0x01 0x1 0x14 0x00 0x00
Response: //Success
Command: ipmitool lan print 1
Response:
......
802.1q VLAN ID : Disabled
Signed-off-by: jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Change-Id: I3d3fe1c9fa5d629fc88f13577d2ac138e9fd4933
To build this package, do the following steps:
1. ./bootstrap.sh
2. ./configure ${CONFIGURE_FLAGS}
3. make
To clean the repository run ./bootstrap.sh clean.