commit 653aec092d86597aa7d7d1259eee58e12310f202
author Alexander Hansen <alexander.hansen@9elements.com> Fri Nov 14 13:38:08 2025 +0100
committer Alexander Hansen <alexander.hansen@9elements.com> Fri Nov 14 14:07:38 2025 +0100
tree 8e8151a988126b5ea581e1dd37fca5cee72ead5e
parent f365c7ffccfaae696694865da3782cf52e62cbef

Sensor.Threshold.*: use PDI constants

Use PDI constants instead of local definitions.

Tested: Inspection only.

Change-Id: Ibb878bc15ac7fa5ec2cae45c5327d2a396e435a0
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

sensordatahandler.hpp

diff --git a/sensordatahandler.hpp b/sensordatahandler.hpp
index 6b716d5..62a4b8b 100644
--- a/sensordatahandler.hpp
+++ b/sensordatahandler.hpp
@@ -10,6 +10,8 @@
 #include <phosphor-logging/elog-errors.hpp>
 #include <phosphor-logging/lg2.hpp>
 #include <sdbusplus/message/types.hpp>
+#include <xyz/openbmc_project/Sensor/Threshold/Critical/common.hpp>
+#include <xyz/openbmc_project/Sensor/Threshold/Warning/common.hpp>
 #include <xyz/openbmc_project/Sensor/Value/common.hpp>
 
 #include <cmath>
@@ -41,6 +43,10 @@
 using PropertyMap = ipmi::PropertyMap;
 
 using SensorValue = sdbusplus::common::xyz::openbmc_project::sensor::Value;
+using SensorThresholdWarning =
+    sdbusplus::common::xyz::openbmc_project::sensor::threshold::Warning;
+using SensorThresholdCritical =
+    sdbusplus::common::xyz::openbmc_project::sensor::threshold::Critical;
 
 using namespace phosphor::logging;
 
@@ -298,8 +304,8 @@
     {
         critAlarmHigh = std::get<bool>(ipmi::getDbusProperty(
             bus, service, sensorInfo.sensorPath,
-            "xyz.openbmc_project.Sensor.Threshold.Critical",
-            "CriticalAlarmHigh"));
+            SensorThresholdCritical::interface,
+            SensorThresholdCritical::property_names::critical_alarm_high));
     }
     catch (const std::exception& e)
     {
@@ -310,8 +316,8 @@
     {
         critAlarmLow = std::get<bool>(ipmi::getDbusProperty(
             bus, service, sensorInfo.sensorPath,
-            "xyz.openbmc_project.Sensor.Threshold.Critical",
-            "CriticalAlarmLow"));
+            SensorThresholdCritical::interface,
+            SensorThresholdCritical::property_names::critical_alarm_low));
     }
     catch (const std::exception& e)
     {
@@ -322,8 +328,8 @@
     {
         warningAlarmHigh = std::get<bool>(ipmi::getDbusProperty(
             bus, service, sensorInfo.sensorPath,
-            "xyz.openbmc_project.Sensor.Threshold.Warning",
-            "WarningAlarmHigh"));
+            SensorThresholdWarning::interface,
+            SensorThresholdWarning::property_names::warning_alarm_high));
     }
     catch (const std::exception& e)
     {
@@ -334,7 +340,8 @@
     {
         warningAlarmLow = std::get<bool>(ipmi::getDbusProperty(
             bus, service, sensorInfo.sensorPath,
-            "xyz.openbmc_project.Sensor.Threshold.Warning", "WarningAlarmLow"));
+            SensorThresholdWarning::interface,
+            SensorThresholdWarning::property_names::warning_alarm_low));
     }
     catch (const std::exception& e)
     {