Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-host-ipmid / 79b4eeaa0c97b40d9ab12b48694083cec2b13d79
commit79b4eeaa0c97b40d9ab12b48694083cec2b13d79[log] [tgz]
authorVernon Mauery <vernon.mauery@linux.intel.com>Thu Nov 07 09:51:39 2019 -0800
committerVernon Mauery <vernon.mauery@linux.intel.com>Mon Nov 11 10:24:03 2019 -0800
tree035b2b8a3efffb2dc6a55c210623a4ee49a33b7f
parent9fc5fa180c3dc0a4fa5ed02efe4b990c40ba641d [diff]
Fix permissions on Get Channel Cipher Suites command

The Get Channel Cipher Suites command should be available at any
privilege level as well as pre-session. This changes it so that it can
be used pre-session to determine the best cipher suite to use. As per
section 22.15 of the IPMI 2.0 spec, "This command can be executed prior
to establishing a session with the BMC." This means that it should be
able to be executed at any privilege, including 'none'.

Tested: run a new version of ipmitool that calls get channel cipher
        suite as part of session initialization before and after. This
        affects all commands, but raw is the shortest to run, so it is
        used here. (raw 6 1 is get device id).

        Before:
        $ ipmitool -I lanplus -H a.b.c.d -U root -P 0penBmc raw 6 1
        Get Channel Cipher Suites failed: Insufficient privilege level
         23 00 00 01 02 bf 57 01 00 7b 00 99 91 cd 13

        After:
        $ ipmitool -I lanplus -H a.b.c.d -U root -P 0penBmc raw 6 1
         23 00 00 01 02 bf 57 01 00 7b 00 99 91 cd 13

Change-Id: I59a3212f1ea5dc82c545e6ec1ee4a437ec5abfe1
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>
1 file changed
tree: 035b2b8a3efffb2dc6a55c210623a4ee49a33b7f
  1. app/
  2. docs/
  3. include/
  4. libipmid/
  5. libipmid-host/
  6. scripts/
  7. softoff/
  8. test/
  9. user_channel/
  10. xyz/
  11. .build.sh
  12. .clang-format
  13. .gitignore
  14. .travis.yml
  15. apphandler.cpp
  16. apphandler.hpp
  17. bootstrap.sh
  18. chassishandler.cpp
  19. chassishandler.hpp
  20. configure.ac
  21. dcmihandler.cpp
  22. dcmihandler.hpp
  23. elog-errors.hpp
  24. entity_map_json.cpp
  25. entity_map_json.hpp
  26. error-HostEvent.hpp
  27. fruread.hpp
  28. generate_whitelist.sh
  29. globalhandler.cpp
  30. globalhandler.hpp
  31. groupext.cpp
  32. host-cmd-manager.cpp
  33. host-cmd-manager.hpp
  34. host-interface.cpp
  35. host-interface.hpp
  36. host-ipmid-whitelist.conf
  37. ipmi_fru_info_area.cpp
  38. ipmi_fru_info_area.hpp
  39. ipmid-new.cpp
  40. ipmisensor.cpp
  41. ipmiwhitelist.hpp
  42. LICENSE
  43. MAINTAINERS
  44. Makefile.am
  45. oemrouter.cpp
  46. read_fru_data.cpp
  47. read_fru_data.hpp
  48. README.md
  49. sample.cpp
  50. sample.h
  51. selutility.cpp
  52. selutility.hpp
  53. sensordatahandler.cpp
  54. sensordatahandler.hpp
  55. sensorhandler.cpp
  56. sensorhandler.hpp
  57. settings.cpp
  58. settings.hpp
  59. storageaddsel.cpp
  60. storageaddsel.hpp
  61. storagehandler.cpp
  62. storagehandler.hpp
  63. sys_info_param.cpp
  64. sys_info_param.hpp
  65. systemintfcmds.cpp
  66. systemintfcmds.hpp
  67. testaddsel.cpp
  68. testit.cpp
  69. transporthandler.cpp
  70. whitelist-filter.cpp
README.md

To build this package, do the following steps:

1. ./bootstrap.sh
2. ./configure ${CONFIGURE_FLAGS}
3. make

To clean the repository run ./bootstrap.sh clean.