Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-host-ipmid / 0e7a8af0e50ad352e290e5ba5d63a3f178fb71d9
commit0e7a8af0e50ad352e290e5ba5d63a3f178fb71d9[log] [tgz]
authorHarvey.Wu <Harvey.Wu@quantatw.com>Fri Jun 10 16:46:46 2022 +0800
committerHarvey Wu <Harvey.Wu@quantatw.com>Thu Jun 16 02:57:42 2022 +0000
tree31fe504c85eb4ec5a689d6ba811769c1f7bddb17
parent4376cdf8fa2c2a6311eb541e767d0dfee470deee [diff]
dbus-sdr: fix the vector size in sdrWriteTable and sdrStatsTable

- The original padEntries size is only 0-255 because the input
  index size is uint8. But if sensor number > 255, the size of
  padEntries will be different from the size of sensor map, so
  the result value when using getWritePermission will be incorrect.

TEST:
Before:
ipmitool raw -l 0 0x04 0x30 0x19 0xff 127 0x00 0x00 0x00 0x00 0x00 0x00 0x00
Unable to send RAW command (channel=0x0 netfn=0x4 lun=0x0 cmd=0x30 rsp=0xce): Command response could not be provided
ipmitool raw -l 1 0x04 0x30 0x19 0xff 127 0x00 0x00 0x00 0x00 0x00 0x00 0x00
Unable to send RAW command (channel=0x0 netfn=0x4 lun=0x1 cmd=0x30 rsp=0xce): Command response could not be provided

After:
ipmitool raw -l 0 0x04 0x30 0x19 0xff 127 0x00 0x00 0x00 0x00 0x00 0x00 0x00
ipmitool raw -l 1 0x04 0x30 0x19 0xff 127 0x00 0x00 0x00 0x00 0x00 0x00 0x00
Unable to send RAW command (channel=0x0 netfn=0x4 lun=0x1 cmd=0x30 rsp=0xce): Command response could not be provided

Signed-off-by: Harvey.Wu <Harvey.Wu@quantatw.com>
Change-Id: Idf6f4f31a1a9d2dd3cc87ebe3a4dc4ca4b283f7c
1 file changed
tree: 31fe504c85eb4ec5a689d6ba811769c1f7bddb17
  1. app/
  2. dbus-sdr/
  3. docs/
  4. include/
  5. libipmid/
  6. libipmid-host/
  7. scripts/
  8. softoff/
  9. subprojects/
  10. test/
  11. user_channel/
  12. xyz/
  13. .build.sh
  14. .clang-format
  15. .gitignore
  16. .shellcheck
  17. .travis.yml
  18. apphandler.cpp
  19. apphandler.hpp
  20. chassishandler.cpp
  21. chassishandler.hpp
  22. dcmihandler.cpp
  23. dcmihandler.hpp
  24. elog-errors.hpp
  25. entity_map_json.cpp
  26. entity_map_json.hpp
  27. error-HostEvent.hpp
  28. fruread.hpp
  29. generate_whitelist.sh
  30. generate_whitelist_create.sh
  31. globalhandler.cpp
  32. globalhandler.hpp
  33. groupext.cpp
  34. host-cmd-manager.cpp
  35. host-cmd-manager.hpp
  36. host-interface.cpp
  37. host-interface.hpp
  38. host-ipmid-whitelist.conf
  39. ipmi_fru_info_area.cpp
  40. ipmi_fru_info_area.hpp
  41. ipmid-new.cpp
  42. ipmisensor.cpp
  43. ipmiwhitelist.hpp
  44. LICENSE
  45. MAINTAINERS
  46. meson.build
  47. meson_options.txt
  48. OWNERS
  49. read_fru_data.cpp
  50. read_fru_data.hpp
  51. README.md
  52. selutility.cpp
  53. selutility.hpp
  54. sensordatahandler.cpp
  55. sensordatahandler.hpp
  56. sensorhandler.cpp
  57. sensorhandler.hpp
  58. settings.cpp
  59. settings.hpp
  60. storageaddsel.cpp
  61. storageaddsel.hpp
  62. storagehandler.cpp
  63. storagehandler.hpp
  64. sys_info_param.cpp
  65. sys_info_param.hpp
  66. systemintfcmds.cpp
  67. systemintfcmds.hpp
  68. testaddsel.cpp
  69. testit.cpp
  70. transporthandler.cpp
  71. transporthandler.hpp
  72. whitelist-filter.cpp
README.md

To build this package, do the following steps:

1. ./bootstrap.sh
2. ./configure ${CONFIGURE_FLAGS}
3. make

To clean the repository run ./bootstrap.sh clean.