commit 70aa8d9677b13eb97e71bc758a09e14e37053565
author Nan Li <william.bjlinan@hotmail.com> Mon Aug 29 00:11:10 2016 +0800
committer Patrick Williams <patrick@stwcx.xyz> Fri Sep 09 20:54:57 2016 +0000
tree e42b5465c43bb01fd44ee0c840a89558d694a41f
parent 37af73315c3e1ff504db466b10e6269cc56dcc6c

Modify respond of un-supported IPMI command

A number of callbacks are registered for 'WILDCARD' types, which
currently do nothing except respond with CC_OK(00h).  Change complete
codes to CC_INVALID(C1h).

Resolves openbmc/openbmc#469.

Change-Id: I91ea5ee1a23284a4159ff1c1867342e89c6fa444
Signed-off-by: Nan Li <william.bjlinan@hotmail.com>

apphandler.cpp

diff --git a/apphandler.cpp b/apphandler.cpp
index 8da85e4..7b64c76 100644
--- a/apphandler.cpp
+++ b/apphandler.cpp
@@ -556,7 +556,7 @@
     printf("Handling WILDCARD Netfn:[0x%X], Cmd:[0x%X]\n",netfn, cmd);
 
     // Status code.
-    ipmi_ret_t rc = IPMI_CC_OK;
+    ipmi_ret_t rc = IPMI_CC_INVALID;
 
     *data_len = strlen("THIS IS WILDCARD");
 

chassishandler.cpp

diff --git a/chassishandler.cpp b/chassishandler.cpp
index 2952725..9a5f169 100644
--- a/chassishandler.cpp
+++ b/chassishandler.cpp
@@ -491,7 +491,7 @@
 {
     printf("Handling CHASSIS WILDCARD Netfn:[0x%X], Cmd:[0x%X]\n",netfn, cmd);
     // Status code.
-    ipmi_ret_t rc = IPMI_CC_OK;
+    ipmi_ret_t rc = IPMI_CC_INVALID;
     *data_len = 0;
     return rc;
 }

sensorhandler.cpp

diff --git a/sensorhandler.cpp b/sensorhandler.cpp
index ea8099d..f906921 100644
--- a/sensorhandler.cpp
+++ b/sensorhandler.cpp
@@ -235,7 +235,7 @@
                              ipmi_request_t request, ipmi_response_t response,
                              ipmi_data_len_t data_len, ipmi_context_t context)
 {
-    ipmi_ret_t rc = IPMI_CC_OK;
+    ipmi_ret_t rc = IPMI_CC_INVALID;
 
     printf("IPMI S/E Wildcard Netfn:[0x%X], Cmd:[0x%X]\n",netfn,cmd);
     *data_len = 0;

storagehandler.cpp

diff --git a/storagehandler.cpp b/storagehandler.cpp
index 9379b0d..01dd41a 100644
--- a/storagehandler.cpp
+++ b/storagehandler.cpp
@@ -21,7 +21,7 @@
 {
     printf("Handling STORAGE WILDCARD Netfn:[0x%X], Cmd:[0x%X]\n",netfn, cmd);
     // Status code.
-    ipmi_ret_t rc = IPMI_CC_OK;
+    ipmi_ret_t rc = IPMI_CC_INVALID;
     *data_len = 0;
     return rc;
 }

transporthandler.cpp

diff --git a/transporthandler.cpp b/transporthandler.cpp
index f7a029b..01a79cb 100644
--- a/transporthandler.cpp
+++ b/transporthandler.cpp
@@ -135,7 +135,7 @@
 {
     printf("Handling TRANSPORT WILDCARD Netfn:[0x%X], Cmd:[0x%X]\n",netfn, cmd);
     // Status code.
-    ipmi_ret_t rc = IPMI_CC_OK;
+    ipmi_ret_t rc = IPMI_CC_INVALID;
     *data_len = 0;
     return rc;
 }