commit 7197b347bb0a11d60b1180683c66ae99e6e47030
author Alexander Hansen <alexander.hansen@9elements.com> Wed Sep 06 11:45:15 2023 +0200
committer Vernon Mauery <vernon.mauery@linux.intel.com> Tue Sep 19 18:29:58 2023 +0000
tree 4bd90e48133f6c6cb4657e3203063c72f02926c4
parent 202702b0b20d0499877b50c5733879e409d43395

more debug logs for ipmi OEM commands

- log IANA as unpacked from request
- log if the request was filtered
- log sucessful / unsucessful registering of OEM Command Handler

Tested: ipmid logs the expected messages.

Change-Id: If4387d2d1927768f697e29d2230d9e3491e8ed48
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

ipmid-new.cpp

diff --git a/ipmid-new.cpp b/ipmid-new.cpp
index a656067..f4951d9 100644
--- a/ipmid-new.cpp
+++ b/ipmid-new.cpp
@@ -187,8 +187,15 @@
     if (!std::get<HandlerBase::ptr>(mapCmd) || std::get<int>(mapCmd) <= prio)
     {
         mapCmd = item;
+        log<level::DEBUG>("registered OEM Handler", entry("IANA=0x%x", iana),
+                          entry("CMD=0x%x", cmd),
+                          entry("netFnCmd=0x%x", netFnCmd));
         return true;
     }
+
+    log<level::WARNING>("could not register OEM Handler",
+                        entry("IANA=0x%x", iana), entry("CMD=0x%x", cmd),
+                        entry("netFnCmd=0x%x", netFnCmd));
     return false;
 }
 
@@ -245,6 +252,7 @@
         // only return the filter response if the command is found
         if (filterResponse)
         {
+            log<level::DEBUG>("request has been filtered");
             return filterResponse;
         }
         HandlerTuple& chosen = cmdIter->second;
@@ -263,6 +271,7 @@
             // only return the filter response if the command is found
             if (filterResponse)
             {
+                log<level::DEBUG>("request has been filtered");
                 return filterResponse;
             }
             HandlerTuple& chosen = cmdIter->second;
@@ -302,6 +311,9 @@
         return errorResponse(request, ccReqDataLenInvalid);
     }
     auto iana = static_cast<Iana>(bytes);
+
+    log<level::DEBUG>("unpack IANA", entry("IANA=0x%x", iana));
+
     message::Response::ptr response = executeIpmiCommandCommon(oemHandlerMap,
                                                                iana, request);
     ipmi::message::Payload prefix;