Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-host-ipmid / 62c05dd8d398eb7a2b5384120fae0a6aae85c9bd
commit62c05dd8d398eb7a2b5384120fae0a6aae85c9bd[log] [tgz]
authorJohnathan Mantey <johnathanx.mantey@intel.com>Wed Nov 20 14:07:44 2019 -0800
committerTom Joseph <tomjoseph@in.ibm.com>Wed Nov 27 00:39:56 2019 +0000
tree8eaaceeed5606dd25750a22d305617cb7f828fd1
parent34698d575975091ebcd95f8b74fa719d6ee7aca6 [diff]
Generate the correct prefix value for IPv4 netmasks 0.0.0.0

When the netmask is assigned the value 0.0.0.0 the prefix is 0, not
33. The algorithm generated an incorrect prefix value when the netmask
was set to 0.0.0.0.

Tested:
ipmitool lan set 3 ipsrc static

ipmitool lan set 3 ipaddr 192.168.20.12
Setting LAN IP Address to 192.168.20.12
2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast qlen 1000
    link/ether 52:3b:aa:7b:0d:d5 brd ff:ff:ff:ff:ff:ff
    inet 192.168.20.12/32 scope global eth0
       valid_lft forever preferred_lft forever
    inet6 fe80::503b:aaff:fe7b:dd5/64 scope link
       valid_lft forever preferred_lft forever

ipmitool lan set 3 netmask 0.0.0.0
Setting LAN Subnet Mask to 0.0.0.0
LAN Parameter Data does not match!  Write may have failed.
2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast qlen 1000
    link/ether 52:3b:aa:7b:0d:d5 brd ff:ff:ff:ff:ff:ff
    inet 169.254.51.116/16 brd 169.254.255.255 scope link eth0
       valid_lft forever preferred_lft forever
    inet6 fe80::503b:aaff:fe7b:dd5/64 scope link
       valid_lft forever preferred_lft forever

ipmitool lan set 3 ipaddr 192.168.20.12
Setting LAN IP Address to 192.168.20.12
ipmitool raw 0xc 1 3 6 0 0 0 0
Unable to send RAW command (channel=0x0 netfn=0xc lun=0x0 cmd=0x1 rsp=0xff): Unspecified error
2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast qlen 1000
    link/ether 52:3b:aa:7b:0d:d5 brd ff:ff:ff:ff:ff:ff
    inet 169.254.51.116/16 brd 169.254.255.255 scope link eth0
       valid_lft forever preferred_lft forever
    inet6 fe80::503b:aaff:fe7b:dd5/64 scope link
       valid_lft forever preferred_lft forever

Change-Id: I94cc02971bf21dabf1f1e22ad078d879393133b8
Signed-off-by: Johnathan Mantey <johnathanx.mantey@intel.com>
1 file changed
tree: 8eaaceeed5606dd25750a22d305617cb7f828fd1
  1. app/
  2. docs/
  3. include/
  4. libipmid/
  5. libipmid-host/
  6. scripts/
  7. softoff/
  8. test/
  9. user_channel/
  10. xyz/
  11. .build.sh
  12. .clang-format
  13. .gitignore
  14. .travis.yml
  15. apphandler.cpp
  16. apphandler.hpp
  17. bootstrap.sh
  18. chassishandler.cpp
  19. chassishandler.hpp
  20. configure.ac
  21. dcmihandler.cpp
  22. dcmihandler.hpp
  23. elog-errors.hpp
  24. entity_map_json.cpp
  25. entity_map_json.hpp
  26. error-HostEvent.hpp
  27. fruread.hpp
  28. generate_whitelist.sh
  29. globalhandler.cpp
  30. globalhandler.hpp
  31. groupext.cpp
  32. host-cmd-manager.cpp
  33. host-cmd-manager.hpp
  34. host-interface.cpp
  35. host-interface.hpp
  36. host-ipmid-whitelist.conf
  37. ipmi_fru_info_area.cpp
  38. ipmi_fru_info_area.hpp
  39. ipmid-new.cpp
  40. ipmisensor.cpp
  41. ipmiwhitelist.hpp
  42. LICENSE
  43. MAINTAINERS
  44. Makefile.am
  45. oemrouter.cpp
  46. read_fru_data.cpp
  47. read_fru_data.hpp
  48. README.md
  49. sample.cpp
  50. sample.h
  51. selutility.cpp
  52. selutility.hpp
  53. sensordatahandler.cpp
  54. sensordatahandler.hpp
  55. sensorhandler.cpp
  56. sensorhandler.hpp
  57. settings.cpp
  58. settings.hpp
  59. storageaddsel.cpp
  60. storageaddsel.hpp
  61. storagehandler.cpp
  62. storagehandler.hpp
  63. sys_info_param.cpp
  64. sys_info_param.hpp
  65. systemintfcmds.cpp
  66. systemintfcmds.hpp
  67. testaddsel.cpp
  68. testit.cpp
  69. transporthandler.cpp
  70. whitelist-filter.cpp
README.md

To build this package, do the following steps:

1. ./bootstrap.sh
2. ./configure ${CONFIGURE_FLAGS}
3. make

To clean the repository run ./bootstrap.sh clean.