Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-host-ipmid / b18c8bc310333719419ca7fedfceb3f7fdabfc17
commitb18c8bc310333719419ca7fedfceb3f7fdabfc17[log] [tgz]
authorAndrew Geissler <geissonator@yahoo.com>Wed Aug 05 15:54:44 2020 -0500
committerAndrew Geissler <geissonator@yahoo.com>Wed Aug 05 15:54:44 2020 -0500
tree553d7e9f9ad202cb4ccfb4511a909fd3bb9b00e8
parent98d28d875c9c800f6a8ec94397833b07bec58f18 [diff]
mapper: remove mapper from host attention path

Error injection testing has shown a significant bottleneck in the host
attention path as the BMC is processing the error and also receiving
commands from an external device requesting writes to the flash.

During this scenario, there are a lot of BMC processes stopping and
starting (as the host is being stopped and error data is collected).
This results in a lot of work for the mapper application. It must delete
its data structure for removed services and introspect all new services.

This heavy workload by mapper not only affects the overall utilization
of the BMC processor, but it also affect any other applications making
D-Bus calls into mapper.

Given the critical nature of this host ipmid code, which is being used
as a part of the protocol with the debug collecting external device,
it's important that mapper not be a bottle neck in this flow. This
commit removes the mapper call from this critical path and just hard
codes the needed service name.

In general, BMC code is moving away from using mapper as a service
lookup application if there is minimal chance of a service being
implemented by multiple applications. In this case, the
org.openbmc.HostIpmi service has had a single implementation since
the beginning of the project.

Tested:
Verified that with this change the error inject was successfully
processed and expected error was logged.

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I4db3b309db0169cbb98a9c0fd7527379a9071287
1 file changed
tree: 553d7e9f9ad202cb4ccfb4511a909fd3bb9b00e8
  1. app/
  2. docs/
  3. include/
  4. libipmid/
  5. libipmid-host/
  6. scripts/
  7. softoff/
  8. test/
  9. user_channel/
  10. xyz/
  11. .build.sh
  12. .clang-format
  13. .gitignore
  14. .travis.yml
  15. apphandler.cpp
  16. apphandler.hpp
  17. bootstrap.sh
  18. chassishandler.cpp
  19. chassishandler.hpp
  20. configure.ac
  21. dcmihandler.cpp
  22. dcmihandler.hpp
  23. elog-errors.hpp
  24. entity_map_json.cpp
  25. entity_map_json.hpp
  26. error-HostEvent.hpp
  27. fruread.hpp
  28. generate_whitelist.sh
  29. globalhandler.cpp
  30. globalhandler.hpp
  31. groupext.cpp
  32. host-cmd-manager.cpp
  33. host-cmd-manager.hpp
  34. host-interface.cpp
  35. host-interface.hpp
  36. host-ipmid-whitelist.conf
  37. ipmi_fru_info_area.cpp
  38. ipmi_fru_info_area.hpp
  39. ipmid-new.cpp
  40. ipmisensor.cpp
  41. ipmiwhitelist.hpp
  42. LICENSE
  43. MAINTAINERS
  44. Makefile.am
  45. read_fru_data.cpp
  46. read_fru_data.hpp
  47. README.md
  48. sample.cpp
  49. sample.h
  50. selutility.cpp
  51. selutility.hpp
  52. sensordatahandler.cpp
  53. sensordatahandler.hpp
  54. sensorhandler.cpp
  55. sensorhandler.hpp
  56. settings.cpp
  57. settings.hpp
  58. storageaddsel.cpp
  59. storageaddsel.hpp
  60. storagehandler.cpp
  61. storagehandler.hpp
  62. sys_info_param.cpp
  63. sys_info_param.hpp
  64. systemintfcmds.cpp
  65. systemintfcmds.hpp
  66. testaddsel.cpp
  67. testit.cpp
  68. transporthandler.cpp
  69. whitelist-filter.cpp
README.md

To build this package, do the following steps:

1. ./bootstrap.sh
2. ./configure ${CONFIGURE_FLAGS}
3. make

To clean the repository run ./bootstrap.sh clean.