commit 785223a6867f7914e9f549cf06655034eea95b4e
author srikanta mondal <srikantax.mondal@intel.com> Fri Apr 10 11:35:32 2020 +0000
committer Vernon Mauery <vernon.mauery@linux.intel.com> Mon Jul 06 22:19:30 2020 +0000
tree 9dea3c6a8d2ba2ddc5e2e6083d71ac2264a738f6
parent 65265369af5efb7b2cfa3b8820d58889240b875b

Removal of OEM privilege setting for User

Issue: Set OEM user Privilege is success for Set user access command

Fix: Set user access - provided fix to deny set OEM user privilege
     for all channel.

Tested:
Before:
Command: ipmitool raw 0x06 0x43 0x93 0x07 0x05 0x00 // Set user access
Response:  // Success

After:
Command: ipmitool raw 0x06 0x43 0x93 0x07 0x05 0x00 // Set user access
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
          cmd=0x43 rsp=0xcc): Invalid data field in request

Signed-off-by: srikanta mondal <srikantax.mondal@intel.com>
Change-Id: Iec38bd15d087a34b2178b8b578dc599817b7e3d1

user_channel/channel_layer.cpp

diff --git a/user_channel/channel_layer.cpp b/user_channel/channel_layer.cpp
index 38fd43f..03b1729 100644
--- a/user_channel/channel_layer.cpp
+++ b/user_channel/channel_layer.cpp
@@ -45,7 +45,8 @@
 bool isValidPrivLimit(const uint8_t privLimit)
 {
     // Callback privilege is deprecated in OpenBMC
-    return ((privLimit > PRIVILEGE_CALLBACK) && (privLimit <= PRIVILEGE_OEM));
+    // At present, "OEM Privilege" is not used in OpenBMC
+    return ((privLimit > PRIVILEGE_CALLBACK) && (privLimit < PRIVILEGE_OEM));
 }
 
 bool isValidAccessMode(const uint8_t accessMode)