Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-host-ipmid / 7adc5a10259086985077a7719c0d6e61d4d73a67
commit7adc5a10259086985077a7719c0d6e61d4d73a67[log] [tgz]
authorHieu Huynh <hieuh@os.amperecomputing.com>Tue Sep 21 12:04:51 2021 +0000
committerVernon Mauery <vernon.mauery@linux.intel.com>Thu Feb 24 00:53:31 2022 +0000
tree5cc86450f0550d2cf4fe85a030cb139de5060396
parent818bea1f2aef6c5298f8b59490916c7250814747 [diff]
Correct IPMI firmware revision report

OpenBMC currently uses firmware revision from the VERSION parameters
from /etc/os-release. While WebUI and Redfish uses entire string for
the revision, IPMI extracts major and minor numbers from that string.
However, phosphor-host-ipmd mistakenly converts the number to
hexa-decimal which make the mismatch between Redfish and IPMI.
This commit fixes the issue by updating the conversion to use decimal
number.

Tested:
1. Tag with v1.11.0001-ampere and check ipmitool mc info report
   firmware revision to 1.11

Signed-off-by: Hieu Huynh <hieuh@os.amperecomputing.com>
Change-Id: I7340827dfc6de6664dde4b58e61197f81b4f89ca
1 file changed
tree: 5cc86450f0550d2cf4fe85a030cb139de5060396
  1. app/
  2. dbus-sdr/
  3. docs/
  4. include/
  5. libipmid/
  6. libipmid-host/
  7. scripts/
  8. softoff/
  9. test/
  10. user_channel/
  11. xyz/
  12. .build.sh
  13. .clang-format
  14. .gitignore
  15. .shellcheck
  16. .travis.yml
  17. apphandler.cpp
  18. apphandler.hpp
  19. bootstrap.sh
  20. chassishandler.cpp
  21. chassishandler.hpp
  22. configure.ac
  23. dcmihandler.cpp
  24. dcmihandler.hpp
  25. elog-errors.hpp
  26. entity_map_json.cpp
  27. entity_map_json.hpp
  28. error-HostEvent.hpp
  29. fruread.hpp
  30. generate_whitelist.sh
  31. globalhandler.cpp
  32. globalhandler.hpp
  33. groupext.cpp
  34. host-cmd-manager.cpp
  35. host-cmd-manager.hpp
  36. host-interface.cpp
  37. host-interface.hpp
  38. host-ipmid-whitelist.conf
  39. ipmi_fru_info_area.cpp
  40. ipmi_fru_info_area.hpp
  41. ipmid-new.cpp
  42. ipmisensor.cpp
  43. ipmiwhitelist.hpp
  44. LICENSE
  45. MAINTAINERS
  46. Makefile.am
  47. OWNERS
  48. read_fru_data.cpp
  49. read_fru_data.hpp
  50. README.md
  51. sample.cpp
  52. sample.h
  53. selutility.cpp
  54. selutility.hpp
  55. sensordatahandler.cpp
  56. sensordatahandler.hpp
  57. sensorhandler.cpp
  58. sensorhandler.hpp
  59. settings.cpp
  60. settings.hpp
  61. storageaddsel.cpp
  62. storageaddsel.hpp
  63. storagehandler.cpp
  64. storagehandler.hpp
  65. sys_info_param.cpp
  66. sys_info_param.hpp
  67. systemintfcmds.cpp
  68. systemintfcmds.hpp
  69. testaddsel.cpp
  70. testit.cpp
  71. transporthandler.cpp
  72. transporthandler.hpp
  73. whitelist-filter.cpp
README.md

To build this package, do the following steps:

1. ./bootstrap.sh
2. ./configure ${CONFIGURE_FLAGS}
3. make

To clean the repository run ./bootstrap.sh clean.