Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-host-ipmid / 6dbea0818b4b19f73ab8bbe9ea90689de96e6db3
commit6dbea0818b4b19f73ab8bbe9ea90689de96e6db3[log] [tgz]
authorVernon Mauery <vernon.mauery@linux.intel.com>Fri Jul 21 11:43:00 2023 -0700
committerVernon Mauery <vernon.mauery@linux.intel.com>Fri Jul 21 11:46:12 2023 -0700
tree78ad72b9010834f029fecf83da412aaf1a6294ef
parent4e02b431f1cf316c12eec1cc085ba105d3c48b33 [diff]
Return error when SDR offset is out of range

When reading SDRs, if the requested offset is beyond the end of the SDR,
we should return an error indicating that the offset is out of range.

Tested:
Confirmed that reading offset 0x40 or 0x41 of a 64-byte SDR return an
error:
ipmitool raw 0xa 0x23 0x01 0x00 0x87 0x00 0x40 0x1
Unable to send RAW command (channel=0x0 netfn=0xa lun=0x0 cmd=0x23
rsp=0xc9): Parameter out of range
ipmitool raw 0xa 0x23 0x01 0x00 0x87 0x00 0x41 0x1
Unable to send RAW command (channel=0x0 netfn=0xa lun=0x0 cmd=0x23
rsp=0xc9): Parameter out of range

Ported from intel-ipmi-oem Change-Id: I3423dddadeb3d2a5e2075ae079d263503ac0679e

Change-Id: Ibb64572a56be06cfad0710fdadafb4791a64513c
Signed-off-by: Jason M. Bills <jason.m.bills@intel.com>
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>
1 file changed
tree: 78ad72b9010834f029fecf83da412aaf1a6294ef
  1. app/
  2. dbus-sdr/
  3. docs/
  4. include/
  5. libipmid/
  6. scripts/
  7. softoff/
  8. subprojects/
  9. test/
  10. user_channel/
  11. xyz/
  12. .build.sh
  13. .clang-format
  14. .gitignore
  15. .shellcheck
  16. .travis.yml
  17. apphandler.cpp
  18. apphandler.hpp
  19. chassishandler.cpp
  20. chassishandler.hpp
  21. dcmihandler.cpp
  22. dcmihandler.hpp
  23. elog-errors.hpp
  24. error-HostEvent.hpp
  25. fruread.hpp
  26. generate_whitelist.sh
  27. generate_whitelist_create.sh
  28. globalhandler.cpp
  29. globalhandler.hpp
  30. groupext.cpp
  31. host-cmd-manager.cpp
  32. host-cmd-manager.hpp
  33. host-interface.cpp
  34. host-interface.hpp
  35. host-ipmid-whitelist.conf
  36. ipmi_fru_info_area.cpp
  37. ipmi_fru_info_area.hpp
  38. ipmid-new.cpp
  39. ipmisensor.cpp
  40. ipmiwhitelist.hpp
  41. LICENSE
  42. meson.build
  43. meson_options.txt
  44. OWNERS
  45. read_fru_data.cpp
  46. read_fru_data.hpp
  47. README.md
  48. selutility.cpp
  49. selutility.hpp
  50. sensordatahandler.cpp
  51. sensordatahandler.hpp
  52. sensorhandler.cpp
  53. sensorhandler.hpp
  54. settings.cpp
  55. settings.hpp
  56. storageaddsel.cpp
  57. storageaddsel.hpp
  58. storagehandler.cpp
  59. storagehandler.hpp
  60. sys_info_param.cpp
  61. sys_info_param.hpp
  62. systemintfcmds.cpp
  63. systemintfcmds.hpp
  64. testaddsel.cpp
  65. testit.cpp
  66. transporthandler.cpp
  67. transporthandler.hpp
  68. whitelist-filter.cpp
README.md

Compile ipmid with default options:

meson builddir
ninja -C builddir

Compile ipmid with yocto defaults:

meson builddir -Dbuildtype=minsize -Db_lto=true -Dtests=disabled
ninja -C builddir

If any of the dependencies are not found on the host system during configuration, meson automatically gets them via its wrap dependencies mentioned in ipmid/subprojects.

Enable/Disable meson wrap feature

meson builddir -Dwrap_mode=nofallback
ninja -C builddir

Enable debug traces

meson builddir -Dbuildtype=debug
ninja -C builddir

Generate test coverage report:

meson builddir -Db_coverage=true -Dtests=enabled
ninja -C builddir test
ninja -C builddir coverage