Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-host-ipmid / 90e81fa2bc1447b1b508200fa05a1b62013ab2d9
commit90e81fa2bc1447b1b508200fa05a1b62013ab2d9[log] [tgz]
authorChalapathi Venkataramashetty <chalapathix.venkataramashetty@intel.com>Tue May 11 09:13:23 2021 +0000
committerVernon Mauery <vernon.mauery@linux.intel.com>Tue Jun 08 17:19:52 2021 +0000
treefa7da86fb2ae5dca087b6a3a8ac1a142f715fa72
parent61024d7df56eb753173ded7fd2ce9cd30a5be800 [diff]
dcmihandler: update data_len to zero when getPowerReading command failed

Issue: heap data is leaked by sending the getPowerReading command

Fix: set the data_len to zero in getPowerReading command so that data is
not leaked when error occurred during getPowerReading.

Tested:

Command: FS1:\cmdtool\> cmdtool.efi 20 B0 02 DC 2c 2d 2f
Response: FF DC

Command: FS1:\cmdtool\> cmdtool.efi 20 B0 02 DC 2c 2d 2f 02 0d DC
Response: FF DC

Signed-off-by: Chalapathi Venkataramashetty <chalapathix.venkataramashetty@intel.com>
Change-Id: I33657439ffd5a632856382715e22377e18258826
1 file changed
tree: fa7da86fb2ae5dca087b6a3a8ac1a142f715fa72
  1. app/
  2. dbus-sdr/
  3. docs/
  4. include/
  5. libipmid/
  6. libipmid-host/
  7. scripts/
  8. softoff/
  9. test/
  10. user_channel/
  11. xyz/
  12. .build.sh
  13. .clang-format
  14. .gitignore
  15. .shellcheck
  16. .travis.yml
  17. apphandler.cpp
  18. apphandler.hpp
  19. bootstrap.sh
  20. chassishandler.cpp
  21. chassishandler.hpp
  22. configure.ac
  23. dcmihandler.cpp
  24. dcmihandler.hpp
  25. elog-errors.hpp
  26. entity_map_json.cpp
  27. entity_map_json.hpp
  28. error-HostEvent.hpp
  29. fruread.hpp
  30. generate_whitelist.sh
  31. globalhandler.cpp
  32. globalhandler.hpp
  33. groupext.cpp
  34. host-cmd-manager.cpp
  35. host-cmd-manager.hpp
  36. host-interface.cpp
  37. host-interface.hpp
  38. host-ipmid-whitelist.conf
  39. ipmi_fru_info_area.cpp
  40. ipmi_fru_info_area.hpp
  41. ipmid-new.cpp
  42. ipmisensor.cpp
  43. ipmiwhitelist.hpp
  44. LICENSE
  45. MAINTAINERS
  46. Makefile.am
  47. read_fru_data.cpp
  48. read_fru_data.hpp
  49. README.md
  50. sample.cpp
  51. sample.h
  52. selutility.cpp
  53. selutility.hpp
  54. sensordatahandler.cpp
  55. sensordatahandler.hpp
  56. sensorhandler.cpp
  57. sensorhandler.hpp
  58. settings.cpp
  59. settings.hpp
  60. storageaddsel.cpp
  61. storageaddsel.hpp
  62. storagehandler.cpp
  63. storagehandler.hpp
  64. sys_info_param.cpp
  65. sys_info_param.hpp
  66. systemintfcmds.cpp
  67. systemintfcmds.hpp
  68. testaddsel.cpp
  69. testit.cpp
  70. transporthandler.cpp
  71. transporthandler.hpp
  72. whitelist-filter.cpp
README.md

To build this package, do the following steps:

1. ./bootstrap.sh
2. ./configure ${CONFIGURE_FLAGS}
3. make

To clean the repository run ./bootstrap.sh clean.