Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-host-ipmid / 54fa13068e049ac8fe866ad2d96f89f1623c6645
commit54fa13068e049ac8fe866ad2d96f89f1623c6645[log] [tgz]
authorMarri Devender Rao <devenrao@in.ibm.com>Mon May 07 01:06:23 2018 -0500
committerVernon Mauery <vernon.mauery@linux.intel.com>Tue May 08 21:53:13 2018 +0000
tree54b5762f370809de63d10901a637621a1816d7a8
parent8171970a5ecfa1aa5b8b80b4418bf0f9fd8304e8 [diff]
Fix get boot options returning unexpected results

Get boot options is returning wrong value when
boot device is set to cdrom followed by setting boot
device to bios.

In the IPMI spec the boot device selector has options
for both "boot source" (default/disk/crdom/network)
and "boot mode" (default/bios/safe/diag). Since this
isn't a bit field, you can't override for eg both the
source and mode at the same time.

The solution is if a set boot device is mapping to a boot
source, then reset the boot mode D-Bus property to default,
or vice versa. This way the ipmid code can determine which
property is not at the default value

Resolves openbmc/openbmc#3067
Resolves openbmc/openbmc#3068

Change-Id: I072c82a161d56f118510fe1f9e5c75cb5c610295
Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>
1 file changed
tree: 54b5762f370809de63d10901a637621a1816d7a8
  1. app/
  2. docs/
  3. host-ipmid/
  4. scripts/
  5. softoff/
  6. test/
  7. xyz/
  8. .build.sh
  9. .gitignore
  10. .travis.yml
  11. apphandler.cpp
  12. apphandler.h
  13. bootstrap.sh
  14. chassishandler.cpp
  15. chassishandler.h
  16. configure.ac
  17. dcmihandler.cpp
  18. dcmihandler.hpp
  19. elog-errors.hpp
  20. error-HostEvent.hpp
  21. fruread.hpp
  22. generate_whitelist.sh
  23. globalhandler.cpp
  24. globalhandler.h
  25. groupext.cpp
  26. host-cmd-manager.cpp
  27. host-cmd-manager.hpp
  28. host-interface.cpp
  29. host-interface.hpp
  30. host-ipmid-whitelist.conf
  31. ipmi_fru_info_area.cpp
  32. ipmi_fru_info_area.hpp
  33. ipmid.cpp
  34. ipmid.hpp
  35. ipmisensor.cpp
  36. ipmiwhitelist.hpp
  37. LICENSE
  38. MAINTAINERS
  39. Makefile.am
  40. net.cpp
  41. net.hpp
  42. read_fru_data.cpp
  43. read_fru_data.hpp
  44. README.md
  45. sample.cpp
  46. sample.h
  47. selutility.cpp
  48. selutility.hpp
  49. sensordatahandler.cpp
  50. sensordatahandler.hpp
  51. sensorhandler.cpp
  52. sensorhandler.h
  53. settings.cpp
  54. settings.hpp
  55. storageaddsel.cpp
  56. storageaddsel.h
  57. storagehandler.cpp
  58. storagehandler.h
  59. systemintfcmds.cpp
  60. systemintfcmds.h
  61. testaddsel.cpp
  62. testit.cpp
  63. timer.cpp
  64. timer.hpp
  65. transporthandler.cpp
  66. transporthandler.hpp
  67. types.hpp
  68. utils.cpp
  69. utils.hpp
README.md

To build this package, do the following steps:

1. ./bootstrap.sh
2. ./configure ${CONFIGURE_FLAGS}
3. make

To clean the repository run ./bootstrap.sh clean.