Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-host-ipmid / 84c49dc17fecc69bdb88dbc7cfb4b67eff81a4e6
commit84c49dc17fecc69bdb88dbc7cfb4b67eff81a4e6[log] [tgz]
authorjayaprakash Mutyala <mutyalax.jayaprakash@intel.com>Mon May 18 23:12:13 2020 +0000
committerJayaprakash Mutyala <mutyalax.jayaprakash@intel.com>Fri Jun 12 17:39:44 2020 +0000
tree62d75993df8f30b1ab369358b932031f7375b48b
parentecd9f378bf5e44d93d8f5be67ef9c20922e2e91a [diff]
transporthandler: Fix for invalid VLAN id

Issue: Set LAN configuration, allowing invalid VLAN ID's and giving
exception when user trying to set VLAN.

Fix: Add condition to return proper error for invalid VLAN ID's and add
a condition to skip exception temporarily.

Tested:
Verified using ipmitool raw commands
Command: ipmitool raw 0x0c 0x01 0x1 0x14 0x00 0x80 //Set Lan, vlan id=0
Response: Unable to send RAW command (channel=0x0 netfn=0xc lun=0x0
          cmd=0x1 rsp=0xcc): Invalid data field in request
Command: ipmitool raw 0x0c 0x01 0x1 0x14 0xff 0x8f
                       //Set Lan, vlan id=4095
Response: Unable to send RAW command (channel=0x0 netfn=0xc lun=0x0
          cmd=0x1 rsp=0xcc): Invalid data field in request
Command: ipmitool raw 0x0c 0x01 0x1 0x14 0x00 0x82
Response:                  //Success

Command: ipmitool lan print 1
Response:
Set in Progress         : Set Complete
Auth Type Support       :
Auth Type Enable        : Callback :
                        : User     :
                        : Operator :
                        : Admin    :
                        : OEM      :
IP Address Source       : DHCP Address
IP Address              : 0.0.0.0
Subnet Mask             : 255.255.255.255
MAC Address             : a6:41:81:e8:39:33
Default Gateway IP      : 10.190.164.1
Default Gateway MAC     : 00:00:00:00:00:00
802.1q VLAN ID          : 512
RMCP+ Cipher Suites     : 17
Cipher Suite Priv Max   : aaaaaaaaaaaaaaa
                        :     X=Cipher Suite Unused
                        :     c=CALLBACK
                        :     u=USER
                        :     o=OPERATOR
                        :     a=ADMIN
                        :     O=OEM
Bad Password Threshold  : Not Available

Command:  ipmitool raw 0x0c 0x01 0x1 0x14 0x00 0x00
Response:                    //Success
Command: ipmitool lan print 1
Response:
......
802.1q VLAN ID          : Disabled

Signed-off-by: jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Change-Id: I3d3fe1c9fa5d629fc88f13577d2ac138e9fd4933
1 file changed
tree: 62d75993df8f30b1ab369358b932031f7375b48b
  1. app/
  2. docs/
  3. include/
  4. libipmid/
  5. libipmid-host/
  6. scripts/
  7. softoff/
  8. test/
  9. user_channel/
  10. xyz/
  11. .build.sh
  12. .clang-format
  13. .gitignore
  14. .travis.yml
  15. apphandler.cpp
  16. apphandler.hpp
  17. bootstrap.sh
  18. chassishandler.cpp
  19. chassishandler.hpp
  20. configure.ac
  21. dcmihandler.cpp
  22. dcmihandler.hpp
  23. elog-errors.hpp
  24. entity_map_json.cpp
  25. entity_map_json.hpp
  26. error-HostEvent.hpp
  27. fruread.hpp
  28. generate_whitelist.sh
  29. globalhandler.cpp
  30. globalhandler.hpp
  31. groupext.cpp
  32. host-cmd-manager.cpp
  33. host-cmd-manager.hpp
  34. host-interface.cpp
  35. host-interface.hpp
  36. host-ipmid-whitelist.conf
  37. ipmi_fru_info_area.cpp
  38. ipmi_fru_info_area.hpp
  39. ipmid-new.cpp
  40. ipmisensor.cpp
  41. ipmiwhitelist.hpp
  42. LICENSE
  43. MAINTAINERS
  44. Makefile.am
  45. read_fru_data.cpp
  46. read_fru_data.hpp
  47. README.md
  48. sample.cpp
  49. sample.h
  50. selutility.cpp
  51. selutility.hpp
  52. sensordatahandler.cpp
  53. sensordatahandler.hpp
  54. sensorhandler.cpp
  55. sensorhandler.hpp
  56. settings.cpp
  57. settings.hpp
  58. storageaddsel.cpp
  59. storageaddsel.hpp
  60. storagehandler.cpp
  61. storagehandler.hpp
  62. sys_info_param.cpp
  63. sys_info_param.hpp
  64. systemintfcmds.cpp
  65. systemintfcmds.hpp
  66. testaddsel.cpp
  67. testit.cpp
  68. transporthandler.cpp
  69. whitelist-filter.cpp
README.md

To build this package, do the following steps:

1. ./bootstrap.sh
2. ./configure ${CONFIGURE_FLAGS}
3. make

To clean the repository run ./bootstrap.sh clean.