Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-host-ipmid / 8a860ea322c9b8d980b8b6a88846f09c8d9f9c4a
commit8a860ea322c9b8d980b8b6a88846f09c8d9f9c4a[log] [tgz]
authorRajashekar Gade Reddy <raja.sekhar.reddy.gade@intel.com>Tue Dec 24 11:31:19 2019 +0530
committerTom Joseph <tomjoseph@in.ibm.com>Wed Feb 19 15:34:27 2020 +0000
tree472b3c70dc94a999943d22230da78fdc57012846
parent51f781418013b993f4b3d5c1572ce19a5b93edf0 [diff]
Return error for BMC and BIOS IPSrc in setLan cmd

openBMC does not have code which supports set lan command with BMC or
BIOS as IP source. So, set lan command with BMC or BIOS as IP source
should not return success it should return an error.

Tested:

Note: ipmitool command internally validates the completion code and
shows the generic message.

ipmitool -I lanplus -U root -P 0penBmc -H <ip_addr> lan set 1 ipsrc
"none"
//success

ipmitool -I lanplus -U root -P 0penBmc -H <ip_addr> lan set 1 ipsrc
"bios"
LAN Parameter Data does not match!  Write may have failed.

ipmitool -I lanplus -U root -P 0penBmc -H <ip_addr> lan set 1 ipsrc
"dhcp"
//success

ipmitool -I lanplus -U root -P 0penBmc -H <ip_addr> lan set 1 ipsrc
"static"
//success

setLan command for IPSrc with ipmitool raw also works fine.

Signed-off-by: Rajashekar Gade Reddy <raja.sekhar.reddy.gade@intel.com>
Change-Id: I75f8b41d5a543a57b3cccb701ee4a660dcd8f030
1 file changed
tree: 472b3c70dc94a999943d22230da78fdc57012846
  1. app/
  2. docs/
  3. include/
  4. libipmid/
  5. libipmid-host/
  6. scripts/
  7. softoff/
  8. test/
  9. user_channel/
  10. xyz/
  11. .build.sh
  12. .clang-format
  13. .gitignore
  14. .travis.yml
  15. apphandler.cpp
  16. apphandler.hpp
  17. bootstrap.sh
  18. chassishandler.cpp
  19. chassishandler.hpp
  20. configure.ac
  21. dcmihandler.cpp
  22. dcmihandler.hpp
  23. elog-errors.hpp
  24. entity_map_json.cpp
  25. entity_map_json.hpp
  26. error-HostEvent.hpp
  27. fruread.hpp
  28. generate_whitelist.sh
  29. globalhandler.cpp
  30. globalhandler.hpp
  31. groupext.cpp
  32. host-cmd-manager.cpp
  33. host-cmd-manager.hpp
  34. host-interface.cpp
  35. host-interface.hpp
  36. host-ipmid-whitelist.conf
  37. ipmi_fru_info_area.cpp
  38. ipmi_fru_info_area.hpp
  39. ipmid-new.cpp
  40. ipmisensor.cpp
  41. ipmiwhitelist.hpp
  42. LICENSE
  43. MAINTAINERS
  44. Makefile.am
  45. read_fru_data.cpp
  46. read_fru_data.hpp
  47. README.md
  48. sample.cpp
  49. sample.h
  50. selutility.cpp
  51. selutility.hpp
  52. sensordatahandler.cpp
  53. sensordatahandler.hpp
  54. sensorhandler.cpp
  55. sensorhandler.hpp
  56. settings.cpp
  57. settings.hpp
  58. storageaddsel.cpp
  59. storageaddsel.hpp
  60. storagehandler.cpp
  61. storagehandler.hpp
  62. sys_info_param.cpp
  63. sys_info_param.hpp
  64. systemintfcmds.cpp
  65. systemintfcmds.hpp
  66. testaddsel.cpp
  67. testit.cpp
  68. transporthandler.cpp
  69. whitelist-filter.cpp
README.md

To build this package, do the following steps:

1. ./bootstrap.sh
2. ./configure ${CONFIGURE_FLAGS}
3. make

To clean the repository run ./bootstrap.sh clean.