commit 8a860ea322c9b8d980b8b6a88846f09c8d9f9c4a
author Rajashekar Gade Reddy <raja.sekhar.reddy.gade@intel.com> Tue Dec 24 11:31:19 2019 +0530
committer Tom Joseph <tomjoseph@in.ibm.com> Wed Feb 19 15:34:27 2020 +0000
tree 472b3c70dc94a999943d22230da78fdc57012846
parent 51f781418013b993f4b3d5c1572ce19a5b93edf0

Return error for BMC and BIOS IPSrc in setLan cmd

openBMC does not have code which supports set lan command with BMC or
BIOS as IP source. So, set lan command with BMC or BIOS as IP source
should not return success it should return an error.

Tested:

Note: ipmitool command internally validates the completion code and
shows the generic message.

ipmitool -I lanplus -U root -P 0penBmc -H <ip_addr> lan set 1 ipsrc
"none"
//success

ipmitool -I lanplus -U root -P 0penBmc -H <ip_addr> lan set 1 ipsrc
"bios"
LAN Parameter Data does not match!  Write may have failed.

ipmitool -I lanplus -U root -P 0penBmc -H <ip_addr> lan set 1 ipsrc
"dhcp"
//success

ipmitool -I lanplus -U root -P 0penBmc -H <ip_addr> lan set 1 ipsrc
"static"
//success

setLan command for IPSrc with ipmitool raw also works fine.

Signed-off-by: Rajashekar Gade Reddy <raja.sekhar.reddy.gade@intel.com>
Change-Id: I75f8b41d5a543a57b3cccb701ee4a660dcd8f030

transporthandler.cpp

diff --git a/transporthandler.cpp b/transporthandler.cpp
index a3b3c35..7b88909 100644
--- a/transporthandler.cpp
+++ b/transporthandler.cpp
@@ -1436,12 +1436,15 @@
                 }
                 case IPSrc::Unspecified:
                 case IPSrc::Static:
-                case IPSrc::BIOS:
-                case IPSrc::BMC:
                 {
                     channelCall<setDHCPProperty>(channel, false);
                     return responseSuccess();
                 }
+                case IPSrc::BIOS:
+                case IPSrc::BMC:
+                {
+                    return responseInvalidFieldRequest();
+                }
             }
             return response(ccParamNotSupported);
         }