Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-host-ipmid / 91875f7749c21f336fc02c957609cb8a24e940b6
commit91875f7749c21f336fc02c957609cb8a24e940b6[log] [tgz]
authorLei YU <mine260309@gmail.com>Tue Apr 03 15:14:49 2018 +0800
committerVernon Mauery <vernon.mauery@linux.intel.com>Tue Apr 10 19:47:13 2018 +0000
treeee462ebbb13b768ba02113eb322f99774633285b
parent65a17a77c25af2e8585bdec21cf004cfb5297ed0 [diff]
Handle sensors that can not be found in SystemManager

When a sensor id is not managed in yaml the code tries to get it from
legacy SystemManager;
And when the sensor id can not be found in SystemManager, it returns
empty path, and cause segment fault.

This commit makes it return -EINVAL when path is empty, and thus the
code will handle this case properly without crash.

Resolves openbmc/openbmc#3062

Tested: Boot host without ipmid crash on Romulus.

Change-Id: I4240b9be54824543b5e795e898330aeb02c5eb90
Signed-off-by: Lei YU <mine260309@gmail.com>
1 file changed
tree: ee462ebbb13b768ba02113eb322f99774633285b
  1. app/
  2. docs/
  3. host-ipmid/
  4. scripts/
  5. softoff/
  6. test/
  7. xyz/
  8. .build.sh
  9. .gitignore
  10. .travis.yml
  11. apphandler.cpp
  12. apphandler.h
  13. bootstrap.sh
  14. chassishandler.cpp
  15. chassishandler.h
  16. configure.ac
  17. dcmihandler.cpp
  18. dcmihandler.hpp
  19. elog-errors.hpp
  20. error-HostEvent.hpp
  21. fruread.hpp
  22. generate_whitelist.sh
  23. globalhandler.cpp
  24. globalhandler.h
  25. groupext.cpp
  26. host-cmd-manager.cpp
  27. host-cmd-manager.hpp
  28. host-interface.cpp
  29. host-interface.hpp
  30. host-ipmid-whitelist.conf
  31. ipmi_fru_info_area.cpp
  32. ipmi_fru_info_area.hpp
  33. ipmid.cpp
  34. ipmid.hpp
  35. ipmisensor.cpp
  36. ipmiwhitelist.hpp
  37. LICENSE
  38. Makefile.am
  39. net.cpp
  40. net.hpp
  41. read_fru_data.cpp
  42. read_fru_data.hpp
  43. README.md
  44. sample.cpp
  45. sample.h
  46. selutility.cpp
  47. selutility.hpp
  48. sensordatahandler.cpp
  49. sensordatahandler.hpp
  50. sensorhandler.cpp
  51. sensorhandler.h
  52. settings.cpp
  53. settings.hpp
  54. storageaddsel.cpp
  55. storageaddsel.h
  56. storagehandler.cpp
  57. storagehandler.h
  58. systemintfcmds.cpp
  59. systemintfcmds.h
  60. testaddsel.cpp
  61. testit.cpp
  62. timer.cpp
  63. timer.hpp
  64. transporthandler.cpp
  65. transporthandler.hpp
  66. types.hpp
  67. utils.cpp
  68. utils.hpp
README.md

To build this package, do the following steps:

1. ./bootstrap.sh
2. ./configure ${CONFIGURE_FLAGS}
3. make

To clean the repository run ./bootstrap.sh clean.