Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-host-ipmid / d385b5a6c358a3664bf97634aa50d558d0cbd4e3
commitd385b5a6c358a3664bf97634aa50d558d0cbd4e3[log] [tgz]
authorJiaqing Zhao <jiaqing.zhao@intel.com>Wed Dec 29 18:31:49 2021 +0800
committerVernon Mauery <vernon.mauery@linux.intel.com>Thu Jan 06 21:38:34 2022 +0000
tree5dafdf703897eca3ee69e90afc662d4e26aa8572
parentd934be9d4b441994e62a4f31094cd20188a69246 [diff]
Fix code logic of setDHCPv6Property

When DHCP is IPv4 only, disabling DHCPv6 by calling setDHCPv6Property
will set DHCP to none, which also disables IPv4. This is an unexpected
behavior caused by current buggy code logic, there is no if condition
meets this situation, so the default value none will be used.

This patch fixes the issue by adopting the same logic as d5967afbbec5
("Fix unexpected change of ipsrc of ipv6").

Tested:
1. current=v4, requested=none => v4
2. Other cases work as expected

Change-Id: I6fef0e464b9789bd78f85219701a170fa9e17285
Signed-off-by: Jiaqing Zhao <jiaqing.zhao@intel.com>
1 file changed
tree: 5dafdf703897eca3ee69e90afc662d4e26aa8572
  1. app/
  2. dbus-sdr/
  3. docs/
  4. include/
  5. libipmid/
  6. libipmid-host/
  7. scripts/
  8. softoff/
  9. test/
  10. user_channel/
  11. xyz/
  12. .build.sh
  13. .clang-format
  14. .gitignore
  15. .shellcheck
  16. .travis.yml
  17. apphandler.cpp
  18. apphandler.hpp
  19. bootstrap.sh
  20. chassishandler.cpp
  21. chassishandler.hpp
  22. configure.ac
  23. dcmihandler.cpp
  24. dcmihandler.hpp
  25. elog-errors.hpp
  26. entity_map_json.cpp
  27. entity_map_json.hpp
  28. error-HostEvent.hpp
  29. fruread.hpp
  30. generate_whitelist.sh
  31. globalhandler.cpp
  32. globalhandler.hpp
  33. groupext.cpp
  34. host-cmd-manager.cpp
  35. host-cmd-manager.hpp
  36. host-interface.cpp
  37. host-interface.hpp
  38. host-ipmid-whitelist.conf
  39. ipmi_fru_info_area.cpp
  40. ipmi_fru_info_area.hpp
  41. ipmid-new.cpp
  42. ipmisensor.cpp
  43. ipmiwhitelist.hpp
  44. LICENSE
  45. MAINTAINERS
  46. Makefile.am
  47. OWNERS
  48. read_fru_data.cpp
  49. read_fru_data.hpp
  50. README.md
  51. sample.cpp
  52. sample.h
  53. selutility.cpp
  54. selutility.hpp
  55. sensordatahandler.cpp
  56. sensordatahandler.hpp
  57. sensorhandler.cpp
  58. sensorhandler.hpp
  59. settings.cpp
  60. settings.hpp
  61. storageaddsel.cpp
  62. storageaddsel.hpp
  63. storagehandler.cpp
  64. storagehandler.hpp
  65. sys_info_param.cpp
  66. sys_info_param.hpp
  67. systemintfcmds.cpp
  68. systemintfcmds.hpp
  69. testaddsel.cpp
  70. testit.cpp
  71. transporthandler.cpp
  72. transporthandler.hpp
  73. whitelist-filter.cpp
README.md

To build this package, do the following steps:

1. ./bootstrap.sh
2. ./configure ${CONFIGURE_FLAGS}
3. make

To clean the repository run ./bootstrap.sh clean.