Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-host-ipmid / 4b0ddb68b4e76420358589213bc400155fa12e43
commit4b0ddb68b4e76420358589213bc400155fa12e43[log] [tgz]
authorLei YU <mine260309@gmail.com>Fri Jan 25 16:43:50 2019 +0800
committerVernon Mauery <vernon.mauery@linux.intel.com>Tue Feb 12 18:02:40 2019 +0000
tree1f439a640b8d6df9799213db644c4a272e6a7f9c
parentcf059392984d089b9044250e44f7ac039c5b032d [diff]
Set init_priority attribute for global variables in shared lib

The code gets unspecified initializatio order for the global/static
variables in a shared library.

If unluck, a global/static variable may be initialized in *constructor*
function, and then initialized by the default contructor.
For exmaple, if `std::unique_ptr<xxx> var{nullptr};` is initialized in
constructor function, below init order may occur:
1. It is initialized in constructor;
2. Then it is initialized as nullptr;
And eventually when the code is to use the variable, we got nullptr.

We met such issues before on openbmc/openbmc#1581, and the technical
details could be found at [this SO question][1] and [this gcc email][2]

The solution is to specify the init_priority attribute, to make the
global/staic variables inititalize earlier than the contructors.

[1]: https://stackoverflow.com/questions/43941159/global-static-variables-initialization-issue-with-attribute-constructor-i
[2]: https://gcc.gnu.org/ml/gcc-patches/2017-03/msg00863.html

Change-Id: I901a6a5cddec12aec9512fe58b16735fa2ad90d7
Signed-off-by: Lei YU <mine260309@gmail.com>
4 files changed
tree: 1f439a640b8d6df9799213db644c4a272e6a7f9c
  1. app/
  2. docs/
  3. include/
  4. libipmid/
  5. libipmid-host/
  6. scripts/
  7. softoff/
  8. test/
  9. user_channel/
  10. xyz/
  11. .build.sh
  12. .clang-format
  13. .gitignore
  14. .travis.yml
  15. apphandler.cpp
  16. apphandler.hpp
  17. bootstrap.sh
  18. chassishandler.cpp
  19. chassishandler.hpp
  20. configure.ac
  21. dcmihandler.cpp
  22. dcmihandler.hpp
  23. elog-errors.hpp
  24. error-HostEvent.hpp
  25. fruread.hpp
  26. generate_whitelist.sh
  27. globalhandler.cpp
  28. globalhandler.hpp
  29. groupext.cpp
  30. host-cmd-manager.cpp
  31. host-cmd-manager.hpp
  32. host-interface.cpp
  33. host-interface.hpp
  34. host-ipmid-whitelist.conf
  35. ipmi_fru_info_area.cpp
  36. ipmi_fru_info_area.hpp
  37. ipmid.cpp
  38. ipmid.hpp
  39. ipmisensor.cpp
  40. ipmiwhitelist.hpp
  41. LICENSE
  42. MAINTAINERS
  43. Makefile.am
  44. oemrouter.cpp
  45. read_fru_data.cpp
  46. read_fru_data.hpp
  47. README.md
  48. sample.cpp
  49. sample.h
  50. selutility.cpp
  51. selutility.hpp
  52. sensordatahandler.cpp
  53. sensordatahandler.hpp
  54. sensorhandler.cpp
  55. sensorhandler.hpp
  56. settings.cpp
  57. settings.hpp
  58. storageaddsel.cpp
  59. storageaddsel.hpp
  60. storagehandler.cpp
  61. storagehandler.hpp
  62. sys_info_param.cpp
  63. sys_info_param.hpp
  64. systemintfcmds.cpp
  65. systemintfcmds.hpp
  66. testaddsel.cpp
  67. testit.cpp
  68. transporthandler.cpp
  69. transporthandler.hpp
  70. types.hpp
  71. utils.cpp
  72. utils.hpp
README.md

To build this package, do the following steps:

1. ./bootstrap.sh
2. ./configure ${CONFIGURE_FLAGS}
3. make

To clean the repository run ./bootstrap.sh clean.