commit a45cb34ff6e6c778e2d2b86518afb8bc0a54d189
author Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com> Mon Dec 03 15:08:59 2018 +0530
committer Vernon Mauery <vernon.mauery@linux.intel.com> Tue Dec 11 14:29:30 2018 +0000
tree 605604911d40cc575c6be9fa927e6922de1e571c
parent ae4b040bd08839efcbc08a78d4f6ce6d77e66050

Update const uint8_t& to const uint8_t

Update const uint8_t& to const uint8_t usage. Passing by reference
for small types are costly than passing it by value and hence the
change is done

Unit-Test
1. Performed build and verified regular user account creation
and RMCP+ login

Change-Id: Ic2dd76795749148f82564677dde2a5db08520454
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>

user_channel/user_mgmt.cpp

diff --git a/user_channel/user_mgmt.cpp b/user_channel/user_mgmt.cpp
index af72540..8ba4a94 100644
--- a/user_channel/user_mgmt.cpp
+++ b/user_channel/user_mgmt.cpp
@@ -508,13 +508,13 @@
     }
 }
 
-UserInfo* UserAccess::getUserInfo(const uint8_t& userId)
+UserInfo* UserAccess::getUserInfo(const uint8_t userId)
 {
     checkAndReloadUserData();
     return &usersTbl.user[userId];
 }
 
-void UserAccess::setUserInfo(const uint8_t& userId, UserInfo* userInfo)
+void UserAccess::setUserInfo(const uint8_t userId, UserInfo* userInfo)
 {
     checkAndReloadUserData();
     std::copy(reinterpret_cast<uint8_t*>(userInfo),
@@ -523,17 +523,17 @@
     writeUserData();
 }
 
-bool UserAccess::isValidChannel(const uint8_t& chNum)
+bool UserAccess::isValidChannel(const uint8_t chNum)
 {
     return (chNum < ipmiMaxChannels);
 }
 
-bool UserAccess::isValidUserId(const uint8_t& userId)
+bool UserAccess::isValidUserId(const uint8_t userId)
 {
     return ((userId <= ipmiMaxUsers) && (userId != reservedUserId));
 }
 
-bool UserAccess::isValidPrivilege(const uint8_t& priv)
+bool UserAccess::isValidPrivilege(const uint8_t priv)
 {
     return ((priv >= PRIVILEGE_CALLBACK && priv <= PRIVILEGE_OEM) ||
             priv == privNoAccess);
@@ -633,7 +633,7 @@
     return true;
 }
 
-ipmi_ret_t UserAccess::setUserEnabledState(const uint8_t& userId,
+ipmi_ret_t UserAccess::setUserEnabledState(const uint8_t userId,
                                            const bool& enabledState)
 {
     if (!isValidUserId(userId))
@@ -660,8 +660,8 @@
     return IPMI_CC_OK;
 }
 
-ipmi_ret_t UserAccess::setUserPrivilegeAccess(const uint8_t& userId,
-                                              const uint8_t& chNum,
+ipmi_ret_t UserAccess::setUserPrivilegeAccess(const uint8_t userId,
+                                              const uint8_t chNum,
                                               const UserPrivAccess& privAccess,
                                               const bool& otherPrivUpdates)
 {
@@ -747,7 +747,7 @@
     return usrIndex;
 }
 
-ipmi_ret_t UserAccess::getUserName(const uint8_t& userId, std::string& userName)
+ipmi_ret_t UserAccess::getUserName(const uint8_t userId, std::string& userName)
 {
     if (!isValidUserId(userId))
     {
@@ -759,7 +759,7 @@
     return IPMI_CC_OK;
 }
 
-ipmi_ret_t UserAccess::setUserName(const uint8_t& userId,
+ipmi_ret_t UserAccess::setUserName(const uint8_t userId,
                                    const char* userNameInChar)
 {
     if (!isValidUserId(userId))