Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-host-ipmid / a6c307a84fe43679ece859789666cca4c391cd38
commita6c307a84fe43679ece859789666cca4c391cd38[log] [tgz]
authorJayanth Othayoth <ojayanth@gmail.com>Sun Dec 08 09:07:14 2024 -0600
committerJayanth Othayoth <ojayanth@gmail.com>Thu Mar 13 23:53:00 2025 -0500
tree2e61cb5f82e77dfacaa17b51653563718b396973
parenta6fb32d899c7b6c19201fc0d4ab7417a47958e33 [diff]
clang-tidy: Fix Dangling Pointer Warning

The following error was reported during clang-tidy enablement due to
a temporary object being destroyed at the end of the full-expression,
leaving a dangling pointer. This fix addresses the issue by changing
str to a proper string instead of a string_view.

'''
0m../apphandler.cpp:545:36: error: object backing the pointer will be destroyed at the end of the full-expression [-Werror
0m../apphandler.cpp:564:40: error: object backing the pointer will be destroyed at the end of the full-expression [-Werror
1m../apphandler.cpp:523:36: error: object backing the pointer will be destroyed at the end of the full-expression [-Werror
'''

Tested: Build and unit testing verified.

Change-Id: I4f8f2dc3f24a4e417e6805075cfaefddb111efaa
Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>
1 file changed
tree: 2e61cb5f82e77dfacaa17b51653563718b396973
  1. app/
  2. dbus-sdr/
  3. docs/
  4. include/
  5. libipmid/
  6. scripts/
  7. softoff/
  8. subprojects/
  9. test/
  10. transport/
  11. user_channel/
  12. xyz/
  13. .build.sh
  14. .clang-format
  15. .gitignore
  16. .shellcheck
  17. .travis.yml
  18. apphandler.cpp
  19. apphandler.hpp
  20. chassishandler.cpp
  21. chassishandler.hpp
  22. dcmihandler.cpp
  23. dcmihandler.hpp
  24. error-HostEvent.hpp
  25. fruread.hpp
  26. generate_whitelist.sh
  27. generate_whitelist_create.sh
  28. globalhandler.cpp
  29. groupext.cpp
  30. host-cmd-manager.cpp
  31. host-cmd-manager.hpp
  32. host-interface.cpp
  33. host-interface.hpp
  34. host-ipmid-whitelist.conf
  35. ipmi_fru_info_area.cpp
  36. ipmi_fru_info_area.hpp
  37. ipmiallowlist.hpp
  38. ipmid-new.cpp
  39. ipmisensor.cpp
  40. LICENSE
  41. meson.build
  42. meson.options
  43. OWNERS
  44. read_fru_data.cpp
  45. read_fru_data.hpp
  46. README.md
  47. selutility.cpp
  48. selutility.hpp
  49. sensordatahandler.cpp
  50. sensordatahandler.hpp
  51. sensorhandler.cpp
  52. sensorhandler.hpp
  53. settings.cpp
  54. settings.hpp
  55. storageaddsel.cpp
  56. storageaddsel.hpp
  57. storagehandler.cpp
  58. sys_info_param.cpp
  59. sys_info_param.hpp
  60. systemintfcmds.cpp
  61. systemintfcmds.hpp
  62. transportconstants.hpp
  63. transporthandler.cpp
  64. transporthandler.hpp
  65. whitelist-filter.cpp
README.md

phosphor-host-ipmid

Compile ipmid with default options

meson builddir
ninja -C builddir

Compile ipmid with yocto defaults

meson builddir -Dbuildtype=minsize -Db_lto=true -Dtests=disabled
ninja -C builddir

If any of the dependencies are not found on the host system during configuration, meson automatically gets them via its wrap dependencies mentioned in ipmid/subprojects.

Enable/Disable meson wrap feature

meson builddir -Dwrap_mode=nofallback
ninja -C builddir

Enable debug traces

meson builddir -Dbuildtype=debug
ninja -C builddir

Generate test coverage report

meson builddir -Db_coverage=true -Dtests=enabled
ninja -C builddir test
ninja -C builddir coverage