Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-host-ipmid / af762de51e47089d87be5a2839cb96ff6dd03321
commitaf762de51e47089d87be5a2839cb96ff6dd03321[log] [tgz]
authorThang Tran <thuutran@amperecomputing.com>Mon Dec 18 11:19:28 2023 +0700
committerVernon Mauery <vernon.mauery@linux.intel.com>Fri Feb 02 19:49:37 2024 +0000
tree12996e2b29dacd979952f31d974ec6fb5343715d
parent0c96fdf819ec17a08516505ae478aa81c68c5435 [diff]
dcmi: correct return data of Get Configuration Parameter command

When users call "ipmitool dcmi get_conf_param" command, ipmitool shows
paramters are disabled or 0.
```
    DHCP Discovery method    :
        Management Controller ID String is disabled
        Vendor class identifier DCMI IANA and Vendor class-specific \
                                        Informationa are disabled
    Initial timeout interval    : 0 seconds
    Server contact timeout interval    : 0 seconds
    Server contact retry interval    : 0 seconds
```

Those information are incorrect. The root cause of this issue due to the
Get DCMI Configuration Command only returns success value w/o parameter
data.

This commit adds parameter data to the response message.

Tested:
    1. Get DCMI Configuration Parameter
       $ipmitool dcmi get_conf_param
    2. Data are shown as below
        ```
        DHCP Discovery method    :
            Management Controller ID String is enabled
            Vendor class identifier DCMI IANA and Vendor class-specific
                                            Informationa are disabled
        Initial timeout interval    : 4 seconds
        Server contact timeout interval    : 120 seconds
        Server contact retry interval    : 64 seconds
        ```

Change-Id: I0089993062c3c30792786b8e7f0f39f9507f93c3
Signed-off-by: Thang Tran <thuutran@amperecomputing.com>
1 file changed
tree: 12996e2b29dacd979952f31d974ec6fb5343715d
  1. app/
  2. dbus-sdr/
  3. docs/
  4. include/
  5. libipmid/
  6. scripts/
  7. softoff/
  8. subprojects/
  9. test/
  10. user_channel/
  11. xyz/
  12. .build.sh
  13. .clang-format
  14. .gitignore
  15. .shellcheck
  16. .travis.yml
  17. apphandler.cpp
  18. apphandler.hpp
  19. chassishandler.cpp
  20. chassishandler.hpp
  21. dcmihandler.cpp
  22. dcmihandler.hpp
  23. error-HostEvent.hpp
  24. fruread.hpp
  25. generate_whitelist.sh
  26. generate_whitelist_create.sh
  27. globalhandler.cpp
  28. globalhandler.hpp
  29. groupext.cpp
  30. host-cmd-manager.cpp
  31. host-cmd-manager.hpp
  32. host-interface.cpp
  33. host-interface.hpp
  34. host-ipmid-whitelist.conf
  35. ipmi_fru_info_area.cpp
  36. ipmi_fru_info_area.hpp
  37. ipmiallowlist.hpp
  38. ipmid-new.cpp
  39. ipmisensor.cpp
  40. LICENSE
  41. meson.build
  42. meson.options
  43. OWNERS
  44. read_fru_data.cpp
  45. read_fru_data.hpp
  46. README.md
  47. selutility.cpp
  48. selutility.hpp
  49. sensordatahandler.cpp
  50. sensordatahandler.hpp
  51. sensorhandler.cpp
  52. sensorhandler.hpp
  53. settings.cpp
  54. settings.hpp
  55. storageaddsel.cpp
  56. storageaddsel.hpp
  57. storagehandler.cpp
  58. storagehandler.hpp
  59. sys_info_param.cpp
  60. sys_info_param.hpp
  61. systemintfcmds.cpp
  62. systemintfcmds.hpp
  63. testaddsel.cpp
  64. testit.cpp
  65. transportconstants.hpp
  66. transporthandler.cpp
  67. transporthandler.hpp
  68. whitelist-filter.cpp
README.md

Compile ipmid with default options:

meson builddir
ninja -C builddir

Compile ipmid with yocto defaults:

meson builddir -Dbuildtype=minsize -Db_lto=true -Dtests=disabled
ninja -C builddir

If any of the dependencies are not found on the host system during configuration, meson automatically gets them via its wrap dependencies mentioned in ipmid/subprojects.

Enable/Disable meson wrap feature

meson builddir -Dwrap_mode=nofallback
ninja -C builddir

Enable debug traces

meson builddir -Dbuildtype=debug
ninja -C builddir

Generate test coverage report:

meson builddir -Db_coverage=true -Dtests=enabled
ninja -C builddir test
ninja -C builddir coverage