commit afd12b4ecc381e21b05e90368ccd29a96ff644b4
author Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com> Tue Jul 07 01:06:57 2020 +0000
committer Vernon Mauery <vernon.mauery@linux.intel.com> Thu Jul 09 18:40:00 2020 +0000
tree 80b60dc6d881f2c71c3e017fe884a344a78bae27
parent 80207e6202d0f2dad62e8c5d9e83704bfe68c07c

Fix for get Channel Info cmd for reserved channels

Issue: Get channel info command returning improper response as "0x82"
       which is not expected for reserved channels 5, 11, 12, 13.

Fix: Return proper completion code for reserved channels.

Tested:
Verified using ipmitool raw commands
Before:
Command:  ipmitool raw 6 0x42 0x05 //get Channel Info
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
          cmd=0x42 rsp=0x82): Unknown (0x82)
Command:  ipmitool raw 6 0x42 0x0b
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
          cmd=0x42 rsp=0x82): Unknown (0x82)
Command:  ipmitool raw 6 0x42 0x0c
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
          cmd=0x42 rsp=0x82): Unknown (0x82)
Command:  ipmitool raw 6 0x42 0x0d
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
          cmd=0x42 rsp=0x82): Unknown (0x82)
After:
Command:  ipmitool raw 6 0x42 0x05 //get Channel Info
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
          cmd=0x42 rsp=0xcc): Invalid data field in request
Command:  ipmitool raw 6 0x42 0x0b
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
          cmd=0x42 rsp=0xcc): Invalid data field in request
Command:  ipmitool raw 6 0x42 0x0c
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
          cmd=0x42 rsp=0xcc): Invalid data field in request
Command:  ipmitool raw 6 0x42 0x0d
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
          cmd=0x42 rsp=0xcc): Invalid data field in request

Signed-off-by: Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Change-Id: Ic5a5bb2317ee301a1ecc37350cbe1b289d33ca38

user_channel/channelcommands.cpp

diff --git a/user_channel/channelcommands.cpp b/user_channel/channelcommands.cpp
index 4bf8071..6987e04 100644
--- a/user_channel/channelcommands.cpp
+++ b/user_channel/channelcommands.cpp
@@ -258,7 +258,7 @@
     if (!isValidChannel(chNum))
     {
         log<level::DEBUG>("Get channel Info - No support on channel");
-        return response(ccActionNotSupportedForChannel);
+        return responseInvalidFieldRequest();
     }
 
     ChannelInfo chInfo;