user_channel:Change fun ret&cmd cc as per New Std
Modified ipmi function return status code and
command completion codes as per new standard.
Tested:
verified using ipmitool commands.
1. create new user
Command : ipmitool user set name 5 user5
Response: //user created successfully
Command: ipmitool user set password 5 0penBmc\' //set password
Response: Set User Password command successful (user 5)
2. Set password
Command : ipmitool user set password 5 0penBmc\'
Response: Set User Password command successful (user 5)
3. set channel access
Command: ipmitool channel setaccess 1 5 callin=on ipmi=on link=on
privilege=4
Response: Set User Access (channel 1 id 5) successful.
4. get channel access
Command: ipmitool channel getaccess 1 5
Response:
Maximum User IDs : 15
Enabled User IDs : 5
User ID : 5
User Name : user5
Fixed Name : No
Access Available : call-in / callback
Link Authentication : enabled
IPMI Messaging : enabled
Privilege Level : ADMINISTRATOR
Enable Status : disabled
5. User list
Command: ipmitool user list 1
Response:
ID Name Callin Link Auth IPMI Msg Channel Priv Limit
1 root false true true ADMINISTRATOR
2 putty_operator true true true OPERATOR
3 ipmi_admin true true true ADMINISTRATOR
4 user2 false true true OPERATOR
5 user5 true true true ADMINISTRATOR
6 true false false NO ACCESS
7 true false false NO ACCESS
8 true false false NO ACCESS
9 true false false NO ACCESS
10 true false false NO ACCESS
11 true false false NO ACCESS
12 true false false NO ACCESS
13 true false false NO ACCESS
14 true false false NO ACCESS
15 true false false NO ACCESS
Signed-off-by: jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Signed-off-by: NITIN SHARMA <nitin1x.sharma@intel.com>
Change-Id: I5f2c32f50edc2de204ac361364e21a61a4bcf237
diff --git a/user_channel/channel_mgmt.hpp b/user_channel/channel_mgmt.hpp
index 80bd6d9..0c31338 100644
--- a/user_channel/channel_mgmt.hpp
+++ b/user_channel/channel_mgmt.hpp
@@ -16,6 +16,7 @@
#pragma once
#include "channel_layer.hpp"
+#include "ipmid/api-types.hpp"
#include <boost/interprocess/sync/file_lock.hpp>
#include <boost/interprocess/sync/named_recursive_mutex.hpp>
@@ -146,19 +147,18 @@
* @param[in] chNum - channel number
* @param[out] chInfo - channel info details
*
- * @return IPMI_CC_OK for success, others for failure.
+ * @return ccSuccess for success, others for failure.
*/
- ipmi_ret_t getChannelInfo(const uint8_t chNum, ChannelInfo& chInfo);
+ Cc getChannelInfo(const uint8_t chNum, ChannelInfo& chInfo);
/** @brief provides channel access data
*
* @param[in] chNum - channel number
* @param[out] chAccessData - channel access data
*
- * @return IPMI_CC_OK for success, others for failure.
+ * @return ccSuccess for success, others for failure.
*/
- ipmi_ret_t getChannelAccessData(const uint8_t chNum,
- ChannelAccess& chAccessData);
+ Cc getChannelAccessData(const uint8_t chNum, ChannelAccess& chAccessData);
/** @brief to set channel access data
*
@@ -166,21 +166,21 @@
* @param[in] chAccessData - channel access data
* @param[in] setFlag - flag to indicate updatable fields
*
- * @return IPMI_CC_OK for success, others for failure.
+ * @return ccSuccess for success, others for failure.
*/
- ipmi_ret_t setChannelAccessData(const uint8_t chNum,
- const ChannelAccess& chAccessData,
- const uint8_t setFlag);
+ Cc setChannelAccessData(const uint8_t chNum,
+ const ChannelAccess& chAccessData,
+ const uint8_t setFlag);
/** @brief to get channel access data persistent data
*
* @param[in] chNum - channel number
* @param[out] chAccessData - channel access data
*
- * @return IPMI_CC_OK for success, others for failure.
+ * @return ccSuccess for success, others for failure.
*/
- ipmi_ret_t getChannelAccessPersistData(const uint8_t chNum,
- ChannelAccess& chAccessData);
+ Cc getChannelAccessPersistData(const uint8_t chNum,
+ ChannelAccess& chAccessData);
/** @brief to set channel access data persistent data
*
@@ -188,21 +188,21 @@
* @param[in] chAccessData - channel access data
* @param[in] setFlag - flag to indicate updatable fields
*
- * @return IPMI_CC_OK for success, others for failure.
+ * @return ccSuccess for success, others for failure.
*/
- ipmi_ret_t setChannelAccessPersistData(const uint8_t chNum,
- const ChannelAccess& chAccessData,
- const uint8_t setFlag);
+ Cc setChannelAccessPersistData(const uint8_t chNum,
+ const ChannelAccess& chAccessData,
+ const uint8_t setFlag);
/** @brief provides supported authentication type for the channel
*
* @param[in] chNum - channel number
* @param[out] authTypeSupported - supported authentication type
*
- * @return IPMI_CC_OK for success, others for failure.
+ * @return ccSuccess for success, others for failure.
*/
- ipmi_ret_t getChannelAuthTypeSupported(const uint8_t chNum,
- uint8_t& authTypeSupported);
+ Cc getChannelAuthTypeSupported(const uint8_t chNum,
+ uint8_t& authTypeSupported);
/** @brief provides enabled authentication type for the channel
*
@@ -210,11 +210,10 @@
* @param[in] priv - privilege
* @param[out] authType - enabled authentication type
*
- * @return IPMI_CC_OK for success, others for failure.
+ * @return ccSuccess for success, others for failure.
*/
- ipmi_ret_t getChannelEnabledAuthType(const uint8_t chNum,
- const uint8_t priv,
- EAuthType& authType);
+ Cc getChannelEnabledAuthType(const uint8_t chNum, const uint8_t priv,
+ EAuthType& authType);
/** @brief conver to channel privilege from system privilege
*