user_channel:Change fun ret&cmd cc as per New Std
Modified ipmi function return status code and
command completion codes as per new standard.
Tested:
verified using ipmitool commands.
1. create new user
Command : ipmitool user set name 5 user5
Response: //user created successfully
Command: ipmitool user set password 5 0penBmc\' //set password
Response: Set User Password command successful (user 5)
2. Set password
Command : ipmitool user set password 5 0penBmc\'
Response: Set User Password command successful (user 5)
3. set channel access
Command: ipmitool channel setaccess 1 5 callin=on ipmi=on link=on
privilege=4
Response: Set User Access (channel 1 id 5) successful.
4. get channel access
Command: ipmitool channel getaccess 1 5
Response:
Maximum User IDs : 15
Enabled User IDs : 5
User ID : 5
User Name : user5
Fixed Name : No
Access Available : call-in / callback
Link Authentication : enabled
IPMI Messaging : enabled
Privilege Level : ADMINISTRATOR
Enable Status : disabled
5. User list
Command: ipmitool user list 1
Response:
ID Name Callin Link Auth IPMI Msg Channel Priv Limit
1 root false true true ADMINISTRATOR
2 putty_operator true true true OPERATOR
3 ipmi_admin true true true ADMINISTRATOR
4 user2 false true true OPERATOR
5 user5 true true true ADMINISTRATOR
6 true false false NO ACCESS
7 true false false NO ACCESS
8 true false false NO ACCESS
9 true false false NO ACCESS
10 true false false NO ACCESS
11 true false false NO ACCESS
12 true false false NO ACCESS
13 true false false NO ACCESS
14 true false false NO ACCESS
15 true false false NO ACCESS
Signed-off-by: jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Signed-off-by: NITIN SHARMA <nitin1x.sharma@intel.com>
Change-Id: I5f2c32f50edc2de204ac361364e21a61a4bcf237
diff --git a/user_channel/channelcommands.cpp b/user_channel/channelcommands.cpp
index adf19d5..714c05a 100644
--- a/user_channel/channelcommands.cpp
+++ b/user_channel/channelcommands.cpp
@@ -26,8 +26,6 @@
namespace ipmi
{
-static constexpr const uint8_t ccActionNotSupportedForChannel = 0x82;
-
/** @brief implements the set channel access command
* @ param ctx - context pointer
* @ param channel - channel number
@@ -124,7 +122,7 @@
if (setNVFlag != 0)
{
compCode = setChannelAccessPersistData(chNum, chNVData, setNVFlag);
- if (compCode != IPMI_CC_OK)
+ if (compCode != ccSuccess)
{
log<level::DEBUG>("Set channel access - Failed to set access data");
return response(compCode);
@@ -134,7 +132,7 @@
if (setActFlag != 0)
{
compCode = setChannelAccessData(chNum, chActData, setActFlag);
- if (compCode != IPMI_CC_OK)
+ if (compCode != ccSuccess)
{
log<level::DEBUG>("Set channel access - Failed to set access data");
return response(compCode);
@@ -206,7 +204,7 @@
compCode = getChannelAccessData(chNum, chAccess);
}
- if (compCode != IPMI_CC_OK)
+ if (compCode != ccSuccess)
{
return response(compCode);
}