commit bac2f1a31eb5d2613ae11b220b28764484d7c06c
author Lei YU <yulei.sh@bytedance.com> Thu Feb 06 06:54:34 2025 +0000
committer Lei YU <yulei.sh@bytedance.com> Tue Mar 04 03:50:52 2025 +0000
tree ee61adac3f49b55b10e9cc5898265a8f4c9a39c6
parent 3145b66f2d69028fc4ee9dda96295c72bf43c374

Enable clang-tidy and apply fixes

Enable clang-tidy, fix the compile issue and fix the clang-tidy issues.

Signed-off-by: Lei YU <yulei.sh@bytedance.com>
Change-Id: I6250c6519a725c07b0cd10abe464fda97a2aebd7

sol/sol_manager.cpp

diff --git a/sol/sol_manager.cpp b/sol/sol_manager.cpp
index 8fabeeb..ccfbc3c 100644
--- a/sol/sol_manager.cpp
+++ b/sol/sol_manager.cpp
@@ -19,7 +19,6 @@
 
 constexpr const char* solInterface = "xyz.openbmc_project.Ipmi.SOL";
 constexpr const char* solPath = "/xyz/openbmc_project/ipmi/sol/";
-constexpr const char* PROP_INTF = "org.freedesktop.DBus.Properties";
 
 namespace sol
 {
@@ -120,7 +119,6 @@
 
 void Manager::updateSOLParameter(uint8_t channelNum)
 {
-    std::variant<uint8_t, bool> value;
     sdbusplus::bus_t dbus(ipmid_get_sd_bus_connection());
     static std::string solService{};
     ipmi::PropertyMap properties;

sol/sol_manager.hpp

diff --git a/sol/sol_manager.hpp b/sol/sol_manager.hpp
index dd857fe..4d7652a 100644
--- a/sol/sol_manager.hpp
+++ b/sol/sol_manager.hpp
@@ -232,7 +232,8 @@
             return *(iter->second);
         }
 
-        std::string msg = "Invalid SOL payload instance " + payloadInstance;
+        std::string msg =
+            "Invalid SOL payload instance " + std::to_string(payloadInstance);
         throw std::runtime_error(msg.c_str());
     }
 
@@ -252,7 +253,7 @@
             }
         }
 
-        std::string msg = "Invalid SOL SessionID " + sessionID;
+        std::string msg = "Invalid SOL SessionID " + std::to_string(sessionID);
         throw std::runtime_error(msg.c_str());
     }