commit bf30c8d31dd7ab923e70eca50829c5996014eaa8
author P Dheeraj Srujan Kumar <p.dheeraj.srujan.kumar@intel.com> Tue Jul 20 04:06:37 2021 +0530
committer Vernon Mauery <vernon.mauery@linux.intel.com> Wed Jul 28 23:54:50 2021 +0000
tree f7ace6880f847c8af000c1182566a1c655633daf
parent 745164ccfd46035e3600d13a1c2d5e763b1dbed4

Fix Kloxwork Issue : NULL check after new

A unique pointer of EVP_CIPHER_CTX is created using EVP_CIPHER_CTX_new()
which could return NULL.
This Commit adds a NULL check to avoid NULL pointer dereferencing and
returns memory error.

Signed-off-by: P Dheeraj Srujan Kumar <p.dheeraj.srujan.kumar@intel.com>
Change-Id: Icbc599210034feb6f7b3c35542bcfff205987628

user_channel/passwd_mgr.cpp

diff --git a/user_channel/passwd_mgr.cpp b/user_channel/passwd_mgr.cpp
index 345f3cc..939f48f 100644
--- a/user_channel/passwd_mgr.cpp
+++ b/user_channel/passwd_mgr.cpp
@@ -177,6 +177,12 @@
         EVP_CIPHER_CTX_new(), ::EVP_CIPHER_CTX_free);
     EVP_CIPHER_CTX_set_padding(ctx.get(), 1);
 
+    if (!ctx)
+    {
+        log<level::DEBUG>("Error: EVP_CIPHER_CTX is NULL");
+        return -ENOMEM;
+    }
+
     // Set key & IV
     int retval = EVP_CipherInit_ex(ctx.get(), cipher, NULL, key, iv,
                                    static_cast<int>(doEncrypt));