Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-host-ipmid / bf47a916bce97ad927d3f6104d070e7eaae2ae8d
commitbf47a916bce97ad927d3f6104d070e7eaae2ae8d[log] [tgz]
authorZev Weiss <zev@bewilderbeest.net>Fri May 21 13:24:47 2021 -0500
committerZev Weiss <zev@bewilderbeest.net>Wed Oct 20 02:48:01 2021 +0000
treec3b7d5e0844827986fd8b048412a90db584a7d42
parenta0bb2a330f29f62c922a0293eaa8d6e89230668d [diff]
dbus-sdr: allow retrieving FRU ID zero

The getFru() function had been unconditionally translating attempts to
access FRU ID 0 to instead access FRU ID 1, making it impossible to
retrieve baseboard FRU information via IPMI:

  $ ipmitool -C17 -I lanplus -U root -P 0penBmc -H $bmc fru print 0
   Device not present (Requested sensor, data, or record not found)

By removing this substitution, IPMI clients can now access baseboard FRU
info.

Tested: 'ipmitool fru print 0' displays the expected baseboard FRU data.

Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
Change-Id: I87b8c299f7bbf4f10bac25484e03cb6df97241a6
1 file changed
tree: c3b7d5e0844827986fd8b048412a90db584a7d42
  1. app/
  2. dbus-sdr/
  3. docs/
  4. include/
  5. libipmid/
  6. libipmid-host/
  7. scripts/
  8. softoff/
  9. test/
  10. user_channel/
  11. xyz/
  12. .build.sh
  13. .clang-format
  14. .gitignore
  15. .shellcheck
  16. .travis.yml
  17. apphandler.cpp
  18. apphandler.hpp
  19. bootstrap.sh
  20. chassishandler.cpp
  21. chassishandler.hpp
  22. configure.ac
  23. dcmihandler.cpp
  24. dcmihandler.hpp
  25. elog-errors.hpp
  26. entity_map_json.cpp
  27. entity_map_json.hpp
  28. error-HostEvent.hpp
  29. fruread.hpp
  30. generate_whitelist.sh
  31. globalhandler.cpp
  32. globalhandler.hpp
  33. groupext.cpp
  34. host-cmd-manager.cpp
  35. host-cmd-manager.hpp
  36. host-interface.cpp
  37. host-interface.hpp
  38. host-ipmid-whitelist.conf
  39. ipmi_fru_info_area.cpp
  40. ipmi_fru_info_area.hpp
  41. ipmid-new.cpp
  42. ipmisensor.cpp
  43. ipmiwhitelist.hpp
  44. LICENSE
  45. MAINTAINERS
  46. Makefile.am
  47. read_fru_data.cpp
  48. read_fru_data.hpp
  49. README.md
  50. sample.cpp
  51. sample.h
  52. selutility.cpp
  53. selutility.hpp
  54. sensordatahandler.cpp
  55. sensordatahandler.hpp
  56. sensorhandler.cpp
  57. sensorhandler.hpp
  58. settings.cpp
  59. settings.hpp
  60. storageaddsel.cpp
  61. storageaddsel.hpp
  62. storagehandler.cpp
  63. storagehandler.hpp
  64. sys_info_param.cpp
  65. sys_info_param.hpp
  66. systemintfcmds.cpp
  67. systemintfcmds.hpp
  68. testaddsel.cpp
  69. testit.cpp
  70. transporthandler.cpp
  71. transporthandler.hpp
  72. whitelist-filter.cpp
README.md

To build this package, do the following steps:

1. ./bootstrap.sh
2. ./configure ${CONFIGURE_FLAGS}
3. make

To clean the repository run ./bootstrap.sh clean.