Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-host-ipmid / c0d01c87c3f0bca8ef949f33c13226d540624cda
commitc0d01c87c3f0bca8ef949f33c13226d540624cda[log] [tgz]
authorGeorge Liu <liuxiwei@ieisystem.com>Tue Jul 08 16:14:36 2025 +0800
committerGeorge Liu <liuxiwei@ieisystem.com>Thu Jul 10 09:07:35 2025 +0800
treed14037cfff7870221fa5d2939e754ee7a3fd07bd
parenta097c214f82e3613efbb64bc7963e2c6a3db60cd [diff]
clang-tidy: fix some warnings

Resolve the following:
```
sys_info_param.cpp:12:11: style: Variable 'callback' can be declared as reference to const [constVariableReference]
    auto& callback = iterator->second;
          ^
include/ipmid/sessionhelper.hpp:49:31: performance: Ineffective call of function 'substr' because a prefix of the string is assigned to itself. Use resize() or pop_back() instead. [uselessCallsSubstr]
            sessionIdString = sessionIdString.substr(0, pos);
                              ^
include/ipmid/sessionhelper.hpp:36:14: style: The scope of the variable 'tempSessionHandle' can be reduced. [variableScope]
    uint16_t tempSessionHandle = 0;
             ^
include/ipmid/sessionhelper.hpp:77:47: performance: Function parameter 'objectPath' should be passed by const reference. [passedByValue]
bool isSessionObjectMatched(const std::string objectPath,
                                              ^
include/ipmid/sessionhelper.hpp:50:31: performance: Ineffective call of function 'substr' because a prefix of the string is assigned to itself. Use resize() or pop_back() instead. [uselessCallsSubstr]
            sessionIdString = sessionIdString.substr(0, pos);
                              ^
transport/serialbridge/test/serial_unittest.cpp:21:13: style: The scope of the variable 'c' can be reduced. [variableScope]
    uint8_t c;
            ^
```

Change-Id: I5a34fc50a95c33367e8b5d67dcb94c46b8def94a
Signed-off-by: George Liu <liuxiwei@ieisystem.com>
3 files changed
tree: d14037cfff7870221fa5d2939e754ee7a3fd07bd
  1. app/
  2. dbus-sdr/
  3. docs/
  4. include/
  5. libipmid/
  6. oem/
  7. scripts/
  8. softoff/
  9. subprojects/
  10. test/
  11. transport/
  12. user_channel/
  13. xyz/
  14. .build.sh
  15. .clang-format
  16. .clang-tidy
  17. .gitignore
  18. .shellcheck
  19. .travis.yml
  20. apphandler.cpp
  21. apphandler.hpp
  22. chassishandler.cpp
  23. chassishandler.hpp
  24. dcmihandler.cpp
  25. dcmihandler.hpp
  26. error-HostEvent.hpp
  27. fruread.hpp
  28. generate_whitelist.sh
  29. generate_whitelist_create.sh
  30. globalhandler.cpp
  31. groupext.cpp
  32. host-cmd-manager.cpp
  33. host-cmd-manager.hpp
  34. host-interface.cpp
  35. host-interface.hpp
  36. host-ipmid-whitelist.conf
  37. ipmi_fru_info_area.cpp
  38. ipmi_fru_info_area.hpp
  39. ipmiallowlist.hpp
  40. ipmid-new.cpp
  41. ipmisensor.cpp
  42. LICENSE
  43. meson.build
  44. meson.options
  45. OWNERS
  46. read_fru_data.cpp
  47. read_fru_data.hpp
  48. README.md
  49. sbmrhandler.cpp
  50. selutility.cpp
  51. selutility.hpp
  52. sensordatahandler.cpp
  53. sensordatahandler.hpp
  54. sensorhandler.cpp
  55. sensorhandler.hpp
  56. settings.cpp
  57. settings.hpp
  58. storageaddsel.cpp
  59. storageaddsel.hpp
  60. storagehandler.cpp
  61. sys_info_param.cpp
  62. sys_info_param.hpp
  63. systemintfcmds.cpp
  64. systemintfcmds.hpp
  65. transportconstants.hpp
  66. transporthandler.cpp
  67. transporthandler.hpp
  68. whitelist-filter.cpp
README.md

phosphor-host-ipmid

Compile ipmid with default options

meson builddir
ninja -C builddir

Compile ipmid with yocto defaults

meson builddir -Dbuildtype=minsize -Db_lto=true -Dtests=disabled
ninja -C builddir

If any of the dependencies are not found on the host system during configuration, meson automatically gets them via its wrap dependencies mentioned in ipmid/subprojects.

Enable/Disable meson wrap feature

meson builddir -Dwrap_mode=nofallback
ninja -C builddir

Enable debug traces

meson builddir -Dbuildtype=debug
ninja -C builddir

Generate test coverage report

meson builddir -Db_coverage=true -Dtests=enabled
ninja -C builddir test
ninja -C builddir coverage