Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-host-ipmid / c178948eae0378e4b7a15f85ff95591033e56dce
commitc178948eae0378e4b7a15f85ff95591033e56dce[log] [tgz]
authorMeera-Katta <meerax.katta@linux.intel.com>Tue May 18 09:53:26 2021 +0000
committerVernon Mauery <vernon.mauery@linux.intel.com>Wed Jul 21 00:26:21 2021 +0000
tree6b8b11a3c2be0ea846578e3de9e526e2c6020e7b
parent55f5d53c0f4fbf5c98d19315c0a3312479e0142f [diff]
Fix for not allow out-of-bounds read in IPMI chnl

Issue: As IPMI channel number assignment starts from 0 to 15, user can
access channel numbers from 0-15 only. If user tried to access IPMI
channel number 16, not throwing out of range error message to the user.
From channel number 17 onwards only throwing out of range error message
to the user.

Fix: Added check to throw out of range error message to the user,
when tried to access channel number equal to or greater than 16.

Tested: Verified using ipmitool raw commands by hacking channel number
to 16 (as IPMI channel_number parameter size is only 4-bits for most of
the IPMI commands) and verified error message.

Signed-off-by: Meera-Katta <meerax.katta@linux.intel.com>
Change-Id: Iac3d8e66bd8cfbbb67aa403f3e19ae18347ea03b
2 files changed
tree: 6b8b11a3c2be0ea846578e3de9e526e2c6020e7b
  1. app/
  2. dbus-sdr/
  3. docs/
  4. include/
  5. libipmid/
  6. libipmid-host/
  7. scripts/
  8. softoff/
  9. test/
  10. user_channel/
  11. xyz/
  12. .build.sh
  13. .clang-format
  14. .gitignore
  15. .shellcheck
  16. .travis.yml
  17. apphandler.cpp
  18. apphandler.hpp
  19. bootstrap.sh
  20. chassishandler.cpp
  21. chassishandler.hpp
  22. configure.ac
  23. dcmihandler.cpp
  24. dcmihandler.hpp
  25. elog-errors.hpp
  26. entity_map_json.cpp
  27. entity_map_json.hpp
  28. error-HostEvent.hpp
  29. fruread.hpp
  30. generate_whitelist.sh
  31. globalhandler.cpp
  32. globalhandler.hpp
  33. groupext.cpp
  34. host-cmd-manager.cpp
  35. host-cmd-manager.hpp
  36. host-interface.cpp
  37. host-interface.hpp
  38. host-ipmid-whitelist.conf
  39. ipmi_fru_info_area.cpp
  40. ipmi_fru_info_area.hpp
  41. ipmid-new.cpp
  42. ipmisensor.cpp
  43. ipmiwhitelist.hpp
  44. LICENSE
  45. MAINTAINERS
  46. Makefile.am
  47. read_fru_data.cpp
  48. read_fru_data.hpp
  49. README.md
  50. sample.cpp
  51. sample.h
  52. selutility.cpp
  53. selutility.hpp
  54. sensordatahandler.cpp
  55. sensordatahandler.hpp
  56. sensorhandler.cpp
  57. sensorhandler.hpp
  58. settings.cpp
  59. settings.hpp
  60. storageaddsel.cpp
  61. storageaddsel.hpp
  62. storagehandler.cpp
  63. storagehandler.hpp
  64. sys_info_param.cpp
  65. sys_info_param.hpp
  66. systemintfcmds.cpp
  67. systemintfcmds.hpp
  68. testaddsel.cpp
  69. testit.cpp
  70. transporthandler.cpp
  71. transporthandler.hpp
  72. whitelist-filter.cpp
README.md

To build this package, do the following steps:

1. ./bootstrap.sh
2. ./configure ${CONFIGURE_FLAGS}
3. make

To clean the repository run ./bootstrap.sh clean.