Fix for not allow out-of-bounds read in IPMI chnl
Issue: As IPMI channel number assignment starts from 0 to 15, user can
access channel numbers from 0-15 only. If user tried to access IPMI
channel number 16, not throwing out of range error message to the user.
From channel number 17 onwards only throwing out of range error message
to the user.
Fix: Added check to throw out of range error message to the user,
when tried to access channel number equal to or greater than 16.
Tested: Verified using ipmitool raw commands by hacking channel number
to 16 (as IPMI channel_number parameter size is only 4-bits for most of
the IPMI commands) and verified error message.
Signed-off-by: Meera-Katta <meerax.katta@linux.intel.com>
Change-Id: Iac3d8e66bd8cfbbb67aa403f3e19ae18347ea03b
diff --git a/apphandler.cpp b/apphandler.cpp
index cbf7fcf..f5db550 100644
--- a/apphandler.cpp
+++ b/apphandler.cpp
@@ -939,7 +939,7 @@
uint8_t getTotalSessionCount()
{
- uint8_t count = 0, ch = 1;
+ uint8_t count = 0, ch = 0;
while (ch < ipmi::maxIpmiChannels &&
count < session::maxNetworkInstanceSupported)