tree df2e0e520833221f57ee6b5bccbba8ea81dace58
parent 3ab2c2b2f3248317d28d717e56b29f19e36fc510
author Brandon Kim <brandonkim@google.com> 1647564846 -0700
committer Willy Tu <wltu@google.com> 1648750322 +0000

apphandler: Fix Device Revision being 0

If the Device Revision is set later, and therefore when convertVersion
returns a negative return value at ipmid startup, we shouldn't be
setting the `haveBMCVersion` flag. Only when the convertVersion returned
a non-negative value and we received a proper Device ID, should we
set the flag.

Tested:
At boot, with a platform with Device Revision 1,

Without the change:
~# ipmitool mc info
Device ID                 : 0
Device Revision           : 0
Firmware Revision         : 16.03

With the change:
~# ipmitool mc info
Device ID                 : 0
Device Revision           : 1
Firmware Revision         : 16.03

Signed-off-by: Brandon Kim <brandonkim@google.com>
Change-Id: Ia7a4e2d21384bb840a082d7ec91ad0ed1722c0c7