Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-host-ipmid / c2566a935dccc19907dea83116f3ced77b529e8b
commitc2566a935dccc19907dea83116f3ced77b529e8b[log] [tgz]
authorjayaprakash Mutyala <mutyalax.jayaprakash@intel.com>Thu Apr 23 21:18:35 2020 +0000
committerVernon Mauery <vernon.mauery@linux.intel.com>Mon May 11 22:41:24 2020 +0000
tree94e7afa5a75c31d706eb47a4b2a446d22b6ccab7
parent1d8579c60732395bd856926c1d6edb99aaf9c327 [diff]
apphandler: Fix for get system info command

Issue: Get system info parameters command giving improper results for
       get revision byte

Fix: Provided fix to return proper completion code for invalid
     get revision byte data

Tested:
Command:  ipmitool raw 0x06 0x59 0xff 0x01 0x00 0x00 //get system info
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
          cmd=0x59 rsp=0xcc): Invalid data field in request
Command:  ipmitool raw 0x06 0x59 0x00 0x01 0x00 0x00
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
          cmd=0x59 rsp=0x80): Unknown (0x80)
Command:  ipmitool raw 0x06 0x59 0x81 0x01 0x00 0x00
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
          cmd=0x59 rsp=0xcc): Invalid data field in request
Command:  ipmitool raw 0x06 0x59 0x80 0x01 0x00 0x00
Response: 11

Signed-off-by: jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Change-Id: I2be9c9a65dfa5b5afbb9314230b0caede822eae9
1 file changed
tree: 94e7afa5a75c31d706eb47a4b2a446d22b6ccab7
  1. app/
  2. docs/
  3. include/
  4. libipmid/
  5. libipmid-host/
  6. scripts/
  7. softoff/
  8. test/
  9. user_channel/
  10. xyz/
  11. .build.sh
  12. .clang-format
  13. .gitignore
  14. .travis.yml
  15. apphandler.cpp
  16. apphandler.hpp
  17. bootstrap.sh
  18. chassishandler.cpp
  19. chassishandler.hpp
  20. configure.ac
  21. dcmihandler.cpp
  22. dcmihandler.hpp
  23. elog-errors.hpp
  24. entity_map_json.cpp
  25. entity_map_json.hpp
  26. error-HostEvent.hpp
  27. fruread.hpp
  28. generate_whitelist.sh
  29. globalhandler.cpp
  30. globalhandler.hpp
  31. groupext.cpp
  32. host-cmd-manager.cpp
  33. host-cmd-manager.hpp
  34. host-interface.cpp
  35. host-interface.hpp
  36. host-ipmid-whitelist.conf
  37. ipmi_fru_info_area.cpp
  38. ipmi_fru_info_area.hpp
  39. ipmid-new.cpp
  40. ipmisensor.cpp
  41. ipmiwhitelist.hpp
  42. LICENSE
  43. MAINTAINERS
  44. Makefile.am
  45. read_fru_data.cpp
  46. read_fru_data.hpp
  47. README.md
  48. sample.cpp
  49. sample.h
  50. selutility.cpp
  51. selutility.hpp
  52. sensordatahandler.cpp
  53. sensordatahandler.hpp
  54. sensorhandler.cpp
  55. sensorhandler.hpp
  56. settings.cpp
  57. settings.hpp
  58. storageaddsel.cpp
  59. storageaddsel.hpp
  60. storagehandler.cpp
  61. storagehandler.hpp
  62. sys_info_param.cpp
  63. sys_info_param.hpp
  64. systemintfcmds.cpp
  65. systemintfcmds.hpp
  66. testaddsel.cpp
  67. testit.cpp
  68. transporthandler.cpp
  69. whitelist-filter.cpp
README.md

To build this package, do the following steps:

1. ./bootstrap.sh
2. ./configure ${CONFIGURE_FLAGS}
3. make

To clean the repository run ./bootstrap.sh clean.