Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-host-ipmid / c2cb1bc28a76cb7b1723add540b836667c5eedeb
commitc2cb1bc28a76cb7b1723add540b836667c5eedeb[log] [tgz]
authorSui Chen <suichen@google.com>Tue Jan 10 02:52:06 2023 -0800
committerSui Chen <suichen@google.com>Thu Feb 16 02:41:19 2023 +0000
treeadb51d4048e5722e4b9f1b02ac8999f62f275b65
parentbd604760285e3def12c59e84f4d0b933827ab775 [diff]
dbus-sdr: Look for ObjectManagers on /xyz/openbmc_project/vr

There are event-only voltage regular control sensors using the code
merged in https://gerrit.openbmc.org/q/hashtag:dbus-sdr-vr-sensors
that install ObjectManagers at /xyz/openbmc_project/vr.

In commit 9a9ac0bcfc2df48873ca0f9725eb5255f7191d84, dbus-sdr was updated
to only look for ObjectManagers located at and under
/xyz/openbmc_project/sensors. This broke the VR daemon as the VR
controls now do not appear in `ipmitool sdr elist event`.

The reason is, before the above commit, dbus-sdr looked for
ObjectManagers located at and under the root path, which involved
both /xyz/openbmc_project/sensors and /xyz/openbmc_project/vr. After the
move, /vr got left out.

This change adds /vr back, so dbus-sdr looks for ObjectManagers on both
paths.

Tested: `ipmitool sdr elist event` makes the VR daemon's event-only IPMI
sensors show up again.

Signed-off-By: Sui Chen <suichen@google.com>
Change-Id: Icab98137a0115e1c5a482cc97598f7dd66d26bfc
1 file changed
tree: adb51d4048e5722e4b9f1b02ac8999f62f275b65
  1. app/
  2. dbus-sdr/
  3. docs/
  4. include/
  5. libipmid/
  6. scripts/
  7. softoff/
  8. subprojects/
  9. test/
  10. user_channel/
  11. xyz/
  12. .build.sh
  13. .clang-format
  14. .gitignore
  15. .shellcheck
  16. .travis.yml
  17. apphandler.cpp
  18. apphandler.hpp
  19. chassishandler.cpp
  20. chassishandler.hpp
  21. dcmihandler.cpp
  22. dcmihandler.hpp
  23. elog-errors.hpp
  24. entity_map_json.cpp
  25. entity_map_json.hpp
  26. error-HostEvent.hpp
  27. fruread.hpp
  28. generate_whitelist.sh
  29. generate_whitelist_create.sh
  30. globalhandler.cpp
  31. globalhandler.hpp
  32. groupext.cpp
  33. host-cmd-manager.cpp
  34. host-cmd-manager.hpp
  35. host-interface.cpp
  36. host-interface.hpp
  37. host-ipmid-whitelist.conf
  38. ipmi_fru_info_area.cpp
  39. ipmi_fru_info_area.hpp
  40. ipmid-new.cpp
  41. ipmisensor.cpp
  42. ipmiwhitelist.hpp
  43. LICENSE
  44. meson.build
  45. meson_options.txt
  46. OWNERS
  47. read_fru_data.cpp
  48. read_fru_data.hpp
  49. README.md
  50. selutility.cpp
  51. selutility.hpp
  52. sensordatahandler.cpp
  53. sensordatahandler.hpp
  54. sensorhandler.cpp
  55. sensorhandler.hpp
  56. settings.cpp
  57. settings.hpp
  58. storageaddsel.cpp
  59. storageaddsel.hpp
  60. storagehandler.cpp
  61. storagehandler.hpp
  62. sys_info_param.cpp
  63. sys_info_param.hpp
  64. systemintfcmds.cpp
  65. systemintfcmds.hpp
  66. testaddsel.cpp
  67. testit.cpp
  68. transporthandler.cpp
  69. transporthandler.hpp
  70. whitelist-filter.cpp
README.md

Compile ipmid with default options:

meson builddir
ninja -C builddir

Compile ipmid with yocto defaults:

meson builddir -Dbuildtype=minsize -Db_lto=true -Dtests=disabled
ninja -C builddir

If any of the dependencies are not found on the host system during configuration, meson automatically gets them via its wrap dependencies mentioned in ipmid/subprojects.

Enable/Disable meson wrap feature

meson builddir -Dwrap_mode=nofallback
ninja -C builddir

Enable debug traces

meson builddir -Dbuildtype=debug
ninja -C builddir

Generate test coverage report:

meson builddir -Db_coverage=true -Dtests=enabled
ninja -C builddir test
ninja -C builddir coverage