Don't report serviceable action if the watchdog service is not present
There were a few cases where a service action was reported because the
watchdog service was not present. It was because of a race condition where
the power down operation is trigerred and the watchdog service is shutdown
but if was followed by a watchdog reset. Since the watchdog service is absent
it resulted in an error log which calls for serviceable action. The IPMI error
response code will report the failure to the host platform software.
Change-Id: Iaf0a860b53fbd85dc451fc4d4a337406ba74e0d6
Signed-off-by: Tom Joseph <tomjoseph@in.ibm.com>
diff --git a/app/watchdog.cpp b/app/watchdog.cpp
index cb71115..03c373e 100644
--- a/app/watchdog.cpp
+++ b/app/watchdog.cpp
@@ -69,13 +69,11 @@
{
const std::string e_str = std::string("wd_reset: ") + e.what();
log<level::ERR>(e_str.c_str());
- reportError();
return ipmi::responseUnspecifiedError();
}
catch (...)
{
log<level::ERR>("wd_reset: Unknown Error");
- reportError();
return ipmi::responseUnspecifiedError();
}
}
@@ -268,13 +266,11 @@
{
const std::string e_str = std::string("wd_set: ") + e.what();
log<level::ERR>(e_str.c_str());
- reportError();
return ipmi::responseUnspecifiedError();
}
catch (...)
{
log<level::ERR>("wd_set: Unknown Error");
- reportError();
return ipmi::responseUnspecifiedError();
}
}
@@ -434,13 +430,11 @@
{
const std::string e_str = std::string("wd_get: ") + e.what();
log<level::ERR>(e_str.c_str());
- reportError();
return ipmi::responseUnspecifiedError();
}
catch (...)
{
log<level::ERR>("wd_get: Unknown Error");
- reportError();
return ipmi::responseUnspecifiedError();
}
}