Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-host-ipmid / cbfa6e1d2bb51f5c38d03a220c79653a0f569e9a
commitcbfa6e1d2bb51f5c38d03a220c79653a0f569e9a[log] [tgz]
authorJohnathan Mantey <johnathanx.mantey@intel.com>Thu Jun 01 06:57:25 2023 -0700
committerVernon Mauery <vernon.mauery@linux.intel.com>Fri Jun 16 18:22:40 2023 +0000
tree98b79d2d5b67fafd572130c6f00f35e2516fa4da
parent49152e76b4c1eb28cef59de5591535387941eee0 [diff]
Block creating IPv4 address 0.0.0.0 via Set LAN Configuration

The IPMI Set LAN Configuration IP Address operation allows any 32-bit
value to be sent to addressed NIC. The current OpenBMC behavior is to
treat all values identically, and insert them into the
systemd-networkd configuration file. This only allows IPMI to write
new values, but to never have a way to remove an entry.

Traditionally IPMI has used 0.0.0.0 to remove a static IP address
entry from being applied to the NIC. This commit implements the
ability to remove an active static IPv4 address by assigning 0.0.0.0
to the NIC.

Preventing 0.0.0.0 from being written to the systemd-networkd
configuration file also prevents systemd-networkd from creating one or
more self assigned 192.x.x.x NAT style addresses.

Tested:
Manually inserted several 'Address=' entries containing valid IPv4
addresses. Rebooted the BMC to enable them.
Issued 'ipmitool raw 12 1 1 3 0 0 0 0' and confirmed no
'Address=0.0.0.0' entry was added to the configuration file.
Confirmed no self assigned NAT addresses were created.
Confirmed one static IPv4 address entry was removed from the config
file.
Repeated 'ipmitool' requests removed one static address per request.

Change-Id: I2ae94750b8f7b80d45b94651464477801064f991
Signed-off-by: Johnathan Mantey <johnathanx.mantey@intel.com>
1 file changed
tree: 98b79d2d5b67fafd572130c6f00f35e2516fa4da
  1. app/
  2. dbus-sdr/
  3. docs/
  4. include/
  5. libipmid/
  6. scripts/
  7. softoff/
  8. subprojects/
  9. test/
  10. user_channel/
  11. xyz/
  12. .build.sh
  13. .clang-format
  14. .gitignore
  15. .shellcheck
  16. .travis.yml
  17. apphandler.cpp
  18. apphandler.hpp
  19. chassishandler.cpp
  20. chassishandler.hpp
  21. dcmihandler.cpp
  22. dcmihandler.hpp
  23. elog-errors.hpp
  24. error-HostEvent.hpp
  25. fruread.hpp
  26. generate_whitelist.sh
  27. generate_whitelist_create.sh
  28. globalhandler.cpp
  29. globalhandler.hpp
  30. groupext.cpp
  31. host-cmd-manager.cpp
  32. host-cmd-manager.hpp
  33. host-interface.cpp
  34. host-interface.hpp
  35. host-ipmid-whitelist.conf
  36. ipmi_fru_info_area.cpp
  37. ipmi_fru_info_area.hpp
  38. ipmid-new.cpp
  39. ipmisensor.cpp
  40. ipmiwhitelist.hpp
  41. LICENSE
  42. meson.build
  43. meson_options.txt
  44. OWNERS
  45. read_fru_data.cpp
  46. read_fru_data.hpp
  47. README.md
  48. selutility.cpp
  49. selutility.hpp
  50. sensordatahandler.cpp
  51. sensordatahandler.hpp
  52. sensorhandler.cpp
  53. sensorhandler.hpp
  54. settings.cpp
  55. settings.hpp
  56. storageaddsel.cpp
  57. storageaddsel.hpp
  58. storagehandler.cpp
  59. storagehandler.hpp
  60. sys_info_param.cpp
  61. sys_info_param.hpp
  62. systemintfcmds.cpp
  63. systemintfcmds.hpp
  64. testaddsel.cpp
  65. testit.cpp
  66. transporthandler.cpp
  67. transporthandler.hpp
  68. whitelist-filter.cpp
README.md

Compile ipmid with default options:

meson builddir
ninja -C builddir

Compile ipmid with yocto defaults:

meson builddir -Dbuildtype=minsize -Db_lto=true -Dtests=disabled
ninja -C builddir

If any of the dependencies are not found on the host system during configuration, meson automatically gets them via its wrap dependencies mentioned in ipmid/subprojects.

Enable/Disable meson wrap feature

meson builddir -Dwrap_mode=nofallback
ninja -C builddir

Enable debug traces

meson builddir -Dbuildtype=debug
ninja -C builddir

Generate test coverage report:

meson builddir -Db_coverage=true -Dtests=enabled
ninja -C builddir test
ninja -C builddir coverage